chore: re-enable the unittest workflow in Owlbot configuration#990
Merged
chelsea-lin merged 2 commits intomainfrom Sep 18, 2024
Merged
chore: re-enable the unittest workflow in Owlbot configuration#990chelsea-lin merged 2 commits intomainfrom
chelsea-lin merged 2 commits intomainfrom
Conversation
product-auto-label
bot
added
size: xs
chelsea-lin
force-pushed
the
main_chelsealin_chore
branch
from
075068e to
0552374
Compare
chelsea-lin
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
chelsea-lin
force-pushed
the
main_chelsealin_chore
branch
from
0552374 to
b5842fa
Compare
chelsea-lin
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
shobsi
reviewed
Sep 17, 2024
Contributor
shobsi
left a comment
shobsi
left a comment
There was a problem hiding this comment.
Does it make something pass that is failing right now? Or it is redundant (we don't need anymore) because the hidden directories are honored by default now?
Contributor
Author
|
@shobsi It is not fixing anything but it's nice to bring the exclude file back to sync up with the upstream template. The file was excluded because of the hidden directories bug was not fixed yet in the template but can be quick fixed in BF. |
shobsi
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is re-enabling the unittest workflow in Owlbot configuration. This workflow was previously disabled in #948 but is now reintroduced due to a fix in Synthtool.