2.11.0 version breaks retrocompatibility with python-bigquery 1.x branch

[drake-mer]

Environment details

• OS type and version:
• Python version: python --version
• pip version: pip --version
• google-api-core version: 2.11.0

Steps to reproduce

Run a bigquery job with python-bigquery v 1.28.2 and google-api-core 2.11.0

Stack trace

TypeError: QueryJob._blocking_poll() got an unexpected keyword argument 'retry'
[...]
    results = query_job.result()  # Waits for job to complete.
  File "/usr/local/lib/python3.10/site-packages/google/cloud/bigquery/job.py", line 3230, in result
    super(QueryJob, self).result(retry=retry, timeout=timeout)
  File "/usr/local/lib/python3.10/site-packages/google/cloud/bigquery/job.py", line 835, in result
    return super(_AsyncJob, self).result(timeout=timeout)
  File "/usr/local/lib/python3.10/site-packages/google/api_core/future/polling.py", line 256, in result
    self._blocking_poll(timeout=timeout, retry=retry, polling=polling)

[tswast]

I suspect a regression with the functionality related to these PRs:

• feat: pass retry from Job.result() to Job.done() python-bigquery#41
• feat(api-core): pass retry from result() to done() #9

Note that we had to be very careful in #9 to make sure we only passed retry back to _blocking_poll if an explicit value for retry was passed in. That way that versions of google-cloud-bigquery that don't have support for that retry value won't fail.

[tswast]

There were unit tests to cover this, so I'm not sure what happened.

[tswast]

I see what happened:

python-api-core/tests/unit/future/test_polling.py

Line 232 in a152ed6

def _blocking_poll(self, timeout=None, retry=None, polling=None):

The test intended to not have a retry argument. Now has a retry argument.

Edit: Likewise, in addition to _blocking_poll similar logic to avoid passing in an unsupported retry argument was removed for done.

[vam-google]

This bug should be fixed in python-bigquery instead (please just make it handle non-numeric default value) #479

[cristianmtr]

I'm also facing this issue. Are there any workarounds?

[vchudnov-g]

Support for the BigQuery v1 branch is ending, as per this comment. Note that the Google OSS Library Breaking Change Policy only provides for a 12-month support window after a new major version of a library is released, and we're beyond that window for BigQuery v1. We encourage you to upgrade to the latest versions of our libraries, and let us know of any problems you encounter.