chore: modify documentation to include failure scenario#3503
Draft
nidhiii-27 wants to merge 1 commit intomainfrom
Draft
chore: modify documentation to include failure scenario#3503nidhiii-27 wants to merge 1 commit intomainfrom
nidhiii-27 wants to merge 1 commit intomainfrom
Conversation
product-auto-label
bot
added
size: s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Javadoc for Storage.get and related methods to clarify that a StorageException is thrown for any failure.
This is to remove confusion over when the method returns null versus when it throws an exception. Specifically, while the methods return null if a resource is definitively not found (HTTP 404), they throw a StorageException for other issues such as missing permissions (HTTP 403).