tests: add centralized VPCSC config detection#9581
Merged
tseaver merged 2 commits intogoogleapis:masterfrom Nov 5, 2019
tseaver:9580-testing-nomralize-vpcsc-config
Merged
tests: add centralized VPCSC config detection#9581tseaver merged 2 commits intogoogleapis:masterfrom tseaver:9580-testing-nomralize-vpcsc-config
tseaver merged 2 commits intogoogleapis:masterfrom
tseaver:9580-testing-nomralize-vpcsc-config
Conversation
googlebot
added
the
cla: yes
See: https://docs.google.com/document/d/1qCRRNqzKn7YnssbB1g-RTkJH11S3vmJ97JjsLWo6alA In particular: - Ensure 'inside_vpcxc' returns True IFF env var is set, regardless of value. - Add 'bucket_outside' test and corresponding skip decorator. - Rename 'skip_*' decorators to clarify semantics. - Expand reason messages in skip decorators to clarify semantics, explain how to enable the skipped test.
Contributor
Author
|
@busunkim96, @crwilcox I believe that b4a9475 brings this PR into line with the documented spec. I will hold off on the client-library-specific changes until this PR is merged. |
busunkim96
approved these changes
Nov 5, 2019
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #9580