Closed
Conversation
googlebot
added
the
cla: yes
Contributor
|
@daspecster Can you write "release notes for humans"? |
Contributor
Author
|
@dhermes the ones with the commit hash are just for the review. The release notes are above the horizontal line I just added. |
Contributor
|
Looks good. |
Contributor
|
Those commits both come from #3084. 95+% of the changes in that PR are unit test only, and don't warrant a release. Also, if you were going to do a release, you should include a link to the PR in the notes (see many of our previous release notes for a template). |
Contributor
Author
|
⚖️ |
Contributor
|
I am fine with just letting these sit in master and waiting until there is an actual feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speech 0.23.1
Specifically: