fix: replace bare except clauses with except Exception

[haosenwang1018]

Replace bare except clauses with except Exception.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @haosenwang1018, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness and maintainability of several Google Cloud client libraries by standardizing exception handling. It specifically addresses the practice of using bare except clauses, replacing them with except Exception to ensure that only application-level errors are caught, thereby preventing the accidental suppression of critical system exceptions. This change promotes more explicit and safer error management across a broad range of generated code.

Highlights

• Improved Exception Handling: Replaced all instances of bare except: clauses with except Exception: to adhere to Python best practices and prevent unintended catching of system-exiting exceptions.
• Widespread Application: This change was systematically applied across numerous REST transport files in various Google Cloud client libraries, including AdManager, DataManager, AI Generative Language, Analytics Admin, Analytics Data, App Engine Admin, API Gateway, API Keys, API Hub, and Artifact Registry.

Changelog

• packages/google-ads-admanager/google/ads/admanager_v1/services/ad_break_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/ad_review_center_ad_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/ad_unit_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/application_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/audience_segment_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/bandwidth_group_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/browser_language_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/browser_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/cms_metadata_key_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/cms_metadata_value_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/company_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/contact_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/content_bundle_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/content_label_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/content_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/creative_template_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/custom_field_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/custom_targeting_key_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/custom_targeting_value_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/device_capability_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/device_category_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/device_manufacturer_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/entity_signals_mapping_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/geo_target_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/line_item_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/mobile_carrier_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/mobile_device_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/mobile_device_submodel_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/network_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/operating_system_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/operating_system_version_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/order_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/placement_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/private_auction_deal_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/private_auction_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/programmatic_buyer_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/report_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/role_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/site_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/taxonomy_category_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/team_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-admanager/google/ads/admanager_v1/services/user_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-datamanager/google/ads/datamanager_v1/services/ingestion_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-datamanager/google/ads/datamanager_v1/services/marketing_data_insights_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-datamanager/google/ads/datamanager_v1/services/partner_link_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-datamanager/google/ads/datamanager_v1/services/user_list_direct_license_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-datamanager/google/ads/datamanager_v1/services/user_list_global_license_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-datamanager/google/ads/datamanager_v1/services/user_list_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ads-marketingplatform-admin/google/ads/marketingplatform_admin_v1alpha/services/marketingplatform_admin_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1/services/generative_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1/services/model_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1alpha/services/cache_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1alpha/services/discuss_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1alpha/services/file_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1alpha/services/generative_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1alpha/services/model_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1alpha/services/permission_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1alpha/services/prediction_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1alpha/services/retriever_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1alpha/services/text_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta/services/cache_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta/services/discuss_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta/services/file_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta/services/generative_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta/services/model_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta/services/permission_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta/services/prediction_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta/services/retriever_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta/services/text_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta2/services/discuss_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta2/services/model_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta2/services/text_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta3/services/discuss_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta3/services/model_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta3/services/permission_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-ai-generativelanguage/google/ai/generativelanguage_v1beta3/services/text_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-analytics-admin/google/analytics/admin_v1beta/services/analytics_admin_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-analytics-data/google/analytics/data_v1alpha/services/alpha_analytics_data/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-analytics-data/google/analytics/data_v1beta/services/beta_analytics_data/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-api-core/google/api_core/timeout.py
  • Replaced bare except clauses with except Exception.
• packages/google-apps-chat/google/apps/chat_v1/services/chat_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-apps-events-subscriptions/google/apps/events_subscriptions_v1/services/subscriptions_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-apps-events-subscriptions/google/apps/events_subscriptions_v1beta/services/subscriptions_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-apps-meet/google/apps/meet_v2/services/conference_records_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-apps-meet/google/apps/meet_v2/services/spaces_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-apps-meet/google/apps/meet_v2beta/services/conference_records_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-apps-meet/google/apps/meet_v2beta/services/spaces_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-area120-tables/google/area120/tables_v1alpha1/services/tables_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-access-approval/google/cloud/accessapproval_v1/services/access_approval/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-advisorynotifications/google/cloud/advisorynotifications_v1/services/advisory_notifications_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-alloydb/google/cloud/alloydb_v1/services/alloy_db_admin/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-alloydb/google/cloud/alloydb_v1/services/alloy_dbcsql_admin/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-alloydb/google/cloud/alloydb_v1alpha/services/alloy_db_admin/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-alloydb/google/cloud/alloydb_v1alpha/services/alloy_dbcsql_admin/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-alloydb/google/cloud/alloydb_v1beta/services/alloy_db_admin/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-alloydb/google/cloud/alloydb_v1beta/services/alloy_dbcsql_admin/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-api-gateway/google/cloud/apigateway_v1/services/api_gateway_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-api-keys/google/cloud/api_keys_v2/services/api_keys/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-apigee-registry/google/cloud/apigee_registry_v1/services/provisioning/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-apigee-registry/google/cloud/apigee_registry_v1/services/registry/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-apihub/google/cloud/apihub_v1/services/api_hub/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-apihub/google/cloud/apihub_v1/services/api_hub_collect/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-apihub/google/cloud/apihub_v1/services/api_hub_curate/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-apihub/google/cloud/apihub_v1/services/api_hub_discovery/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-apihub/google/cloud/apihub_v1/services/api_hub_plugin/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-apihub/google/cloud/apihub_v1/services/provisioning/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-apihub/google/cloud/apihub_v1/services/runtime_project_attachment_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-apiregistry/google/cloud/apiregistry_v1beta/services/cloud_api_registry/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-appengine-admin/google/cloud/appengine_admin_v1/services/applications/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-appengine-admin/google/cloud/appengine_admin_v1/services/authorized_certificates/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-appengine-admin/google/cloud/appengine_admin_v1/services/authorized_domains/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-appengine-admin/google/cloud/appengine_admin_v1/services/domain_mappings/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-appengine-admin/google/cloud/appengine_admin_v1/services/firewall/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-appengine-admin/google/cloud/appengine_admin_v1/services/instances/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-appengine-admin/google/cloud/appengine_admin_v1/services/services/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-appengine-admin/google/cloud/appengine_admin_v1/services/versions/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-apphub/google/cloud/apphub_v1/services/app_hub/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-artifact-registry/google/cloud/artifactregistry_v1/services/artifact_registry/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-artifact-registry/google/cloud/artifactregistry_v1beta2/services/artifact_registry/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-asset/google/cloud/asset_v1/services/asset_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-asset/google/cloud/asset_v1p1beta1/services/asset_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-asset/google/cloud/asset_v1p2beta1/services/asset_service/transports/rest.py
  • Replaced bare except clauses with except Exception.
• packages/google-cloud-asset/google/cloud/asset_v1p5beta1/services/asset_service/transports/rest.py
  • Replaced bare except clauses with except Exception.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request systematically replaces bare except: clauses with except Exception:. This is a valuable improvement to the codebase as it prevents catching system-exiting exceptions like SystemExit and KeyboardInterrupt, making the error handling more robust and predictable. The changes are applied consistently across a large number of files.

[parthea]

Hi @haosenwang1018, Thanks for opening a PR! Regrettably, the files in this PR are automatically generated using a code generator in https://github.com/googleapis/gapic-generator-python. If you're interested to submit a fix there, pull requests are welcome! The source of truth lives here: https://github.com/googleapis/gapic-generator-python/blob/535d65420751b5959f8e960ee532726da00159b6/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/transports/rest.py.j2#L275

Once the fix is merged in gapic-generator-python, it will be rolled out to google-cloud-python automatically using our tooling which is referred to as librarian.