chore(pubsub): bump copyright year to 2020 (via synth)#10236
chore(pubsub): bump copyright year to 2020 (via synth)#10236yoshi-automation wants to merge 1 commit intomasterfrom
Conversation
…nt library generator.
|
|
||
|
|
||
| # TODO: remove conditional import after Python 2 support is dropped | ||
| if six.PY3: |
There was a problem hiding this comment.
I didn't notice this when this change was being reviewed, but we'd have to make this change to the templates in gapic-generator to make this permanent. I don't anticipate us staying on the monolith(or supporting Python 2) past the first half of this year.
@plamut Would you be alright with letting this change be reverted? A synth replace is also an option if you feel it is important for Pub/Sub in particular.
Mostly trying to clear out synth PRs before repo split on Friday :)
There was a problem hiding this comment.
@busunkim96 You mean reverting the change back to checking "if PY3"?
While this fix by an external contributor was welcome, it won't be applicable in the foreseeable future, as Python 4 has not been announced yet, and it's nearly certain that Python 2 support will be dropped way before that.
Feel free to do anything that makes the job on your part easier. :)
plamut
left a comment
There was a problem hiding this comment.
Looks good, I just have a question about a backslash.
The synth.metadata diff seems larger than usual (I might be wrong), but I assume that's correct. :)
| Attributes: | ||
| service_account_email: | ||
| `Service account email | ||
| \ `Service account email |
There was a problem hiding this comment.
What's the role of this backslash here? 😕
(could it be some kind of a leftover or a generator bug?)
|
Starting the repo split, please do not merge. |
|
Closing, googleapis/python-pubsub#25 is the equivalent in the new repo. |
This PR was generated using Autosynth. 🌈
Commits in this repo since last synth:
01b7fb9 docs(bigquery): typo fix (#10209)
9ad21f4 feat(core): change default api_request() timeout to non-None (#10219)
8a0e129 fix(automl): fix TablesClient.predict for array and struct (#9991)
7e36fda deprecate(bigquery): deprecate
client.dataset()in favor ofDatasetReference(#7753)73eac04 chore(recommender): release 0.2.0 (#10204)
c411e14 feat(recommender): add v1, set release level to beta (#10170)
8e7b7f8 feat(api_core): add retry param into PollingFuture() and it's inheritors (#9923)
0280a94 feat(bigquery): check
rowsargument type ininsert_rows()(#10174)3c4335d feat(bigquerydatatransfer): add
service_account_nameoption to transfer configs (#10013)a51da49 test(datacatalog): run unit tests with Python 3.8 (#10014)
c61c238 fix: be permssive about merging an empty struct (#10079)
Log from Synthtool