Add AttachedDisk class, related configurations and tests#917
Add AttachedDisk class, related configurations and tests#917mziccard merged 2 commits intogoogleapis:compute-alphafrom
Conversation
|
Changes Unknown when pulling 6e93362 on mziccard:compute-attached-disk into * on GoogleCloudPlatform:compute-alpha*. |
|
I am confused. The associated link, attached disks specify that both PERSISTENT AND SCRATCH are valid options as a disk type. |
I guess that is just a copy-paste from the description of an attached disk resource. In reality if I try to pass either a scratch disk or create a persistent disk on the fly ( {
"error": {
"errors": [
{
"domain": "global",
"reason": "invalid",
"message": "Invalid value for field 'resource.initializeParams': ''. Cannot specify initialize params during attach disk, the persistent disk must exist."
}
],
"code": 400,
"message": "Invalid value for field 'resource.initializeParams': ''. Cannot specify initialize params during attach disk, the persistent disk must exist."
}
}Which made me conclude that only attaching an existing persistent disk is supported. |
c15cd91 to
ba8b011
Compare
| * will use the first partition of the disk for its root filesystem. If not specified, the | ||
| * disk is not used as a boot disk. | ||
| * instance will use the first partition of the disk for its root filesystem. If not | ||
| * specified, the isk is not used as a boot disk. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
As discuessed in #928 I like this approach better. Looks good to me but I didn't look carefully at the details. |
…onfig to v1.5.0 (#917) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.4.0` -> `1.5.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.5.0`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#​150-httpsgithubcomgoogleapisjava-shared-configcomparev140v150-2022-06-10) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.4.0...v1.5.0) ##### Features - add build scripts for native image testing in Java 17 ([#​1440](https://togithub.com/googleapis/java-shared-config/issues/1440)) ([#​475](https://togithub.com/googleapis/java-shared-config/issues/475)) ([e4dfc1b](https://togithub.com/googleapis/java-shared-config/commit/e4dfc1ba29295158c78c8fcf94467d2a6a33538a)) - to produce Java 8 compatible bytecode when using JDK 9+ ([2468276](https://togithub.com/googleapis/java-shared-config/commit/2468276145cdfe1ca911b52f765e026e77661a09)) ##### Dependencies - update surefire.version to v3.0.0-m7 ([bbfe663](https://togithub.com/googleapis/java-shared-config/commit/bbfe66393af3e49612c9c1e4334ba39c133ea1d0)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).
Source-Link: googleapis/synthtool@18d4e9b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45
…-info-reports-plugin to v3.4.1 (#917) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-monitoring). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTkuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE1OS4xIn0=-->
🤖 I have created a release *beep* *boop* --- ## [4.0.5](googleapis/java-dataproc@v4.0.4...v4.0.5) (2022-09-16) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#915](googleapis/java-dataproc#915)) ([f1b89a1](googleapis/java-dataproc@f1b89a1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [3.0.10](https://togithub.com/googleapis/java-recaptchaenterprise/compare/v3.0.9...v3.0.10) (2022-09-30) ### Dependencies * Update dependency cachetools to v5 ([#912](https://togithub.com/googleapis/java-recaptchaenterprise/issues/912)) ([4159fc9](https://togithub.com/googleapis/java-recaptchaenterprise/commit/4159fc9c2ba53bc563a7e09f3d27822cad14ede7)) * Update dependency certifi to v2022.9.24 ([#900](https://togithub.com/googleapis/java-recaptchaenterprise/issues/900)) ([53295c2](https://togithub.com/googleapis/java-recaptchaenterprise/commit/53295c27b5f6e6bd158c28724c19a61c04151b1f)) * Update dependency charset-normalizer to v2.1.1 ([#907](https://togithub.com/googleapis/java-recaptchaenterprise/issues/907)) ([b37e4be](https://togithub.com/googleapis/java-recaptchaenterprise/commit/b37e4befa4100a81194c5377f36e85118968627f)) * Update dependency gcp-releasetool to v1.8.8 ([#903](https://togithub.com/googleapis/java-recaptchaenterprise/issues/903)) ([1d64421](https://togithub.com/googleapis/java-recaptchaenterprise/commit/1d64421af98f2e77df87f2560b1afce4394f67f8)) * Update dependency google-auth to v2.11.1 ([#904](https://togithub.com/googleapis/java-recaptchaenterprise/issues/904)) ([6828992](https://togithub.com/googleapis/java-recaptchaenterprise/commit/682899284938f44285dce994dc54f6a330bcad2b)) * Update dependency google-cloud-core to v2.3.2 ([#905](https://togithub.com/googleapis/java-recaptchaenterprise/issues/905)) ([cbdf325](https://togithub.com/googleapis/java-recaptchaenterprise/commit/cbdf325035285d2e446ae73794b67bb653d15488)) * Update dependency googleapis-common-protos to v1.56.4 ([#906](https://togithub.com/googleapis/java-recaptchaenterprise/issues/906)) ([5050174](https://togithub.com/googleapis/java-recaptchaenterprise/commit/5050174da1fc1e7ef450c7eed7d1626d42353e26)) * Update dependency markupsafe to v2.1.1 ([#901](https://togithub.com/googleapis/java-recaptchaenterprise/issues/901)) ([b69312b](https://togithub.com/googleapis/java-recaptchaenterprise/commit/b69312b49dc9ea402e49838fd0d19ad29e1e648c)) * Update dependency org.seleniumhq.selenium:selenium-chrome-driver to v4.5.0 ([#916](https://togithub.com/googleapis/java-recaptchaenterprise/issues/916)) ([7f3c8f5](https://togithub.com/googleapis/java-recaptchaenterprise/commit/7f3c8f509715d5e0e5bbe9ed0f23d3c06b9be192)) * Update dependency org.seleniumhq.selenium:selenium-java to v4.5.0 ([#917](https://togithub.com/googleapis/java-recaptchaenterprise/issues/917)) ([4c55f09](https://togithub.com/googleapis/java-recaptchaenterprise/commit/4c55f09c717c2d20aeebbe73a5e3744d369a4d95)) * Update dependency protobuf to v3.20.2 ([#902](https://togithub.com/googleapis/java-recaptchaenterprise/issues/902)) ([aca7cfb](https://togithub.com/googleapis/java-recaptchaenterprise/commit/aca7cfbad09d106025602a61079ca3e9a9d9fda1)) * Update dependency protobuf to v4 ([#913](https://togithub.com/googleapis/java-recaptchaenterprise/issues/913)) ([0b2ab6b](https://togithub.com/googleapis/java-recaptchaenterprise/commit/0b2ab6b246758e6d411679cd156e6f935a9d4f13)) * Update dependency pyjwt to v2.5.0 ([#908](https://togithub.com/googleapis/java-recaptchaenterprise/issues/908)) ([a3e1c2f](https://togithub.com/googleapis/java-recaptchaenterprise/commit/a3e1c2f178073ef0f17ea338040b6859337b0146)) * Update dependency requests to v2.28.1 ([#909](https://togithub.com/googleapis/java-recaptchaenterprise/issues/909)) ([bbe8f9b](https://togithub.com/googleapis/java-recaptchaenterprise/commit/bbe8f9bd59ed333959a33a815326fe973d0aab7c)) * Update dependency typing-extensions to v4.3.0 ([#910](https://togithub.com/googleapis/java-recaptchaenterprise/issues/910)) ([6b2630e](https://togithub.com/googleapis/java-recaptchaenterprise/commit/6b2630eaeed410409f6d0521b6a6bd7fc435f905)) * Update dependency zipp to v3.8.1 ([#911](https://togithub.com/googleapis/java-recaptchaenterprise/issues/911)) ([e94c7c0](https://togithub.com/googleapis/java-recaptchaenterprise/commit/e94c7c0ee03a2ea2035e33308c87059fdeb06499)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.11.0](https://togithub.com/googleapis/java-securitycenter/compare/v2.10.0...v2.11.0) (2022-10-03) ### Features * Added parent display name i.e. source display name for a finding as one of the finding attributes ([#915](https://togithub.com/googleapis/java-securitycenter/issues/915)) ([034d25a](https://togithub.com/googleapis/java-securitycenter/commit/034d25a3191ccc82dd4e9fe69124af3c24b1029f)) ### Dependencies * Update dependency cachetools to v5 ([#933](https://togithub.com/googleapis/java-securitycenter/issues/933)) ([5b2b39d](https://togithub.com/googleapis/java-securitycenter/commit/5b2b39dabf51c323316033c558efce77c2c19bf9)) * Update dependency com.google.cloud:google-cloud-bigquery to v2.16.1 ([#917](https://togithub.com/googleapis/java-securitycenter/issues/917)) ([58ed894](https://togithub.com/googleapis/java-securitycenter/commit/58ed8942ca8012cf0456bfe431d21e7d553f1fd0)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.16 ([#913](https://togithub.com/googleapis/java-securitycenter/issues/913)) ([1eaf4b3](https://togithub.com/googleapis/java-securitycenter/commit/1eaf4b3b295ba7e248f88ef14a377d1e865ac5c3)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.17 ([#923](https://togithub.com/googleapis/java-securitycenter/issues/923)) ([60d65d3](https://togithub.com/googleapis/java-securitycenter/commit/60d65d35a3c50f8cedeb8ef9b4db0480d667a976)) * Update dependency com.google.cloud:google-cloud-pubsub to v1.120.18 ([#924](https://togithub.com/googleapis/java-securitycenter/issues/924)) ([f94db64](https://togithub.com/googleapis/java-securitycenter/commit/f94db64c37b4e0c734ee8bd42a6d174feb2251ba)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#937](https://togithub.com/googleapis/java-securitycenter/issues/937)) ([001091d](https://togithub.com/googleapis/java-securitycenter/commit/001091d1d178d81e3cec06f3847687c8905be49a)) * Update dependency com.google.protobuf:protobuf-java-util to v3.21.6 ([#914](https://togithub.com/googleapis/java-securitycenter/issues/914)) ([992d37a](https://togithub.com/googleapis/java-securitycenter/commit/992d37a4fe95b598b638d159aa86e41e324a63ff)) * Update dependency com.google.protobuf:protobuf-java-util to v3.21.7 ([#935](https://togithub.com/googleapis/java-securitycenter/issues/935)) ([2353016](https://togithub.com/googleapis/java-securitycenter/commit/23530169d5c988e30c9a1c43a0405243dd6614ad)) * Update dependency markupsafe to v2.1.1 ([#927](https://togithub.com/googleapis/java-securitycenter/issues/927)) ([2c42b32](https://togithub.com/googleapis/java-securitycenter/commit/2c42b32a1831e08a8f0f5e4e600e18ca075d5c10)) * Update dependency protobuf to v3.20.2 ([#928](https://togithub.com/googleapis/java-securitycenter/issues/928)) ([faf7200](https://togithub.com/googleapis/java-securitycenter/commit/faf72009d3deea9bd869cc6e93a08d28325f2ace)) * Update dependency protobuf to v4 ([#934](https://togithub.com/googleapis/java-securitycenter/issues/934)) ([19f8da3](https://togithub.com/googleapis/java-securitycenter/commit/19f8da31814ae8f957b142655c45cdcb5254c696)) * Update dependency pyjwt to v2.5.0 ([#929](https://togithub.com/googleapis/java-securitycenter/issues/929)) ([a5b8ae2](https://togithub.com/googleapis/java-securitycenter/commit/a5b8ae2802dfaea8745eab65fa7c4ac83ebd973e)) * Update dependency requests to v2.28.1 ([#930](https://togithub.com/googleapis/java-securitycenter/issues/930)) ([ca80e91](https://togithub.com/googleapis/java-securitycenter/commit/ca80e911c33af260892a95998d15c1dd024c67d4)) * Update dependency typing-extensions to v4.3.0 ([#931](https://togithub.com/googleapis/java-securitycenter/issues/931)) ([12fda13](https://togithub.com/googleapis/java-securitycenter/commit/12fda1317eb93337827ee03918b91d0c3cbe1a15)) * Update dependency zipp to v3.8.1 ([#932](https://togithub.com/googleapis/java-securitycenter/issues/932)) ([15a6c7f](https://togithub.com/googleapis/java-securitycenter/commit/15a6c7f01f4e6da74e037852857af1e0cceaad11)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ### [3.7.3](googleapis/java-logging@v3.7.2...v3.7.3) (2022-03-29) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.9.0 ([#917](googleapis/java-logging#917)) ([b42717e](googleapis/java-logging@b42717e)) * update dependency com.google.cloud:native-image-support to v0.12.11 ([#916](googleapis/java-logging#916)) ([6d6bbef](googleapis/java-logging@6d6bbef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [2.13.0](https://togithub.com/googleapis/java-datastore/compare/v2.12.5...v2.13.0) (2022-12-06) ### Features * Next release from main branch is 2.13.0 ([#917](https://togithub.com/googleapis/java-datastore/issues/917)) ([1f12435](https://togithub.com/googleapis/java-datastore/commit/1f1243577cbdc206b6a0bfcde818411eb1b806ad)) ### Bug Fixes * [#355](https://togithub.com/googleapis/java-datastore/issues/355) Explicitly passing --project argument when starting emulator ([#923](https://togithub.com/googleapis/java-datastore/issues/923)) ([ef4065d](https://togithub.com/googleapis/java-datastore/commit/ef4065d233b968f58a34673aa53d39f60a013e2d)) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([#932](https://togithub.com/googleapis/java-datastore/issues/932)) ([1dbcea7](https://togithub.com/googleapis/java-datastore/commit/1dbcea73827961148800c1ec8e87065dbceb6c88)) * Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.18 ([#924](https://togithub.com/googleapis/java-datastore/issues/924)) ([625e896](https://togithub.com/googleapis/java-datastore/commit/625e89685172ae546a813f5f7184223d01fbb0ac)) * Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.19 ([#930](https://togithub.com/googleapis/java-datastore/issues/930)) ([77285be](https://togithub.com/googleapis/java-datastore/commit/77285be97fbd6bca1ada35202842238e306dd8dc)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.18 ([#925](https://togithub.com/googleapis/java-datastore/issues/925)) ([0c7539d](https://togithub.com/googleapis/java-datastore/commit/0c7539d736ec993d7bb0531d7cd4dab1b08487a0)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.19 ([#931](https://togithub.com/googleapis/java-datastore/issues/931)) ([40b4011](https://togithub.com/googleapis/java-datastore/commit/40b4011e3a826a91e33541efdecb05f0e129f87c)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
* feat: Adds Pluggable Auth support to ADC (#895) * chore(deps): update dependency com.google.http-client:google-http-client-bom to v1.41.5 (#896) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.http-client:google-http-client-bom](https://togithub.com/googleapis/google-http-java-client) | `1.41.4` -> `1.41.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/google-http-java-client</summary> ### [`v1.41.5`](https://togithub.com/googleapis/google-http-java-client/blob/HEAD/CHANGELOG.md#​1415-httpsgithubcomgoogleapisgoogle-http-java-clientcomparev1414v1415-2022-03-21) [Compare Source](https://togithub.com/googleapis/google-http-java-client/compare/v1.41.4...v1.41.5) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java). * feat: Add ability to provide PrivateKey as Pkcs8 encoded string #883 (#889) * feat: Add ability to provide PrivateKey as Pkcs8 encoded string #883 This change adds a new method `setPrivateKeyString` in `ServiceAccountCredentials.Builder` to accept Pkcs8 encoded string representation of private keys. Co-authored-by: Timur Sadykov <stim@google.com> * chore: fix downstream check (#898) * fix: update branding in ExternalAccountCredentials (#893) These changes align the Javadoc comments with the branding that Google uses externally: + STS -> Security Token Service + GCP -> Google Cloud + Remove references to a Google-internal token type Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/google-auth-library-java/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass: Tests are failing, but I don't think that was caused by the changes in this PR - [ ] Code coverage does not decrease (if any source code was changed): n/a - [ ] Appropriate docs were updated (if necessary): n/a * feat: Adds the ExecutableHandler interface for Pluggable Auth * feat: Adds a Pluggable Auth specific exception * feat: Adds new PluggableAuthCredentials class that plug into ADC * feat: Adds unit tests for PluggableAuthCredentials and ExternalAccountCredentials * Add units tests for GoogleCredentials * fix: update javadoc/comments * fix: A concrete ExecutableOptions implementation is not needed * review: javadoc changes + constants Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Navina Ramesh <navi.trinity@gmail.com> Co-authored-by: Timur Sadykov <stim@google.com> Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com> Co-authored-by: Jeff Williams <jeffrey.l.williams@gmail.com> * feat: finalizes PluggableAuth implementation (#906) * Adds ExecutableResponse class * Adds unit tests for ExecutableResponse * Adds 3rd party executable handler * Adds unit tests for PluggableAuthHandler * Fix build issues * don't fail on javadoc errors * feat: Improve Pluggable Auth error handling (#912) * feat: improves pluggable auth error handling * cleanup * fix: consume input stream immediately for Pluggable Auth (#915) * feat: improves pluggable auth error handling * cleanup * fix: consume input stream immediately so that the spawned process will not hang if the STDOUT buffer is filled. * fix: fix merge * fix: review comments * fix: refactor to keep ImpersonatedCredentials final (#917) * fix: adds more documentation for InternalProcessBuilder and moves it to the bottom of the file * fix: keep ImpersonatedCredentials final * fix: make sure executor is shutdown Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Navina Ramesh <navi.trinity@gmail.com> Co-authored-by: Timur Sadykov <stim@google.com> Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com> Co-authored-by: Jeff Williams <jeffrey.l.williams@gmail.com> Co-authored-by: Emily Ball <emilyball@google.com>
* feat: Adds Pluggable Auth support to ADC (#895) * chore(deps): update dependency com.google.http-client:google-http-client-bom to v1.41.5 (#896) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.http-client:google-http-client-bom](https://togithub.com/googleapis/google-http-java-client) | `1.41.4` -> `1.41.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/google-http-java-client</summary> ### [`v1.41.5`](https://togithub.com/googleapis/google-http-java-client/blob/HEAD/CHANGELOG.md#​1415-httpsgithubcomgoogleapisgoogle-http-java-clientcomparev1414v1415-2022-03-21) [Compare Source](https://togithub.com/googleapis/google-http-java-client/compare/v1.41.4...v1.41.5) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java). * feat: Add ability to provide PrivateKey as Pkcs8 encoded string #883 (#889) * feat: Add ability to provide PrivateKey as Pkcs8 encoded string #883 This change adds a new method `setPrivateKeyString` in `ServiceAccountCredentials.Builder` to accept Pkcs8 encoded string representation of private keys. Co-authored-by: Timur Sadykov <stim@google.com> * chore: fix downstream check (#898) * fix: update branding in ExternalAccountCredentials (#893) These changes align the Javadoc comments with the branding that Google uses externally: + STS -> Security Token Service + GCP -> Google Cloud + Remove references to a Google-internal token type Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/google-auth-library-java/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass: Tests are failing, but I don't think that was caused by the changes in this PR - [ ] Code coverage does not decrease (if any source code was changed): n/a - [ ] Appropriate docs were updated (if necessary): n/a * feat: Adds the ExecutableHandler interface for Pluggable Auth * feat: Adds a Pluggable Auth specific exception * feat: Adds new PluggableAuthCredentials class that plug into ADC * feat: Adds unit tests for PluggableAuthCredentials and ExternalAccountCredentials * Add units tests for GoogleCredentials * fix: update javadoc/comments * fix: A concrete ExecutableOptions implementation is not needed * review: javadoc changes + constants Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Navina Ramesh <navi.trinity@gmail.com> Co-authored-by: Timur Sadykov <stim@google.com> Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com> Co-authored-by: Jeff Williams <jeffrey.l.williams@gmail.com> * feat: finalizes PluggableAuth implementation (#906) * Adds ExecutableResponse class * Adds unit tests for ExecutableResponse * Adds 3rd party executable handler * Adds unit tests for PluggableAuthHandler * Fix build issues * don't fail on javadoc errors * feat: Improve Pluggable Auth error handling (#912) * feat: improves pluggable auth error handling * cleanup * fix: consume input stream immediately for Pluggable Auth (#915) * feat: improves pluggable auth error handling * cleanup * fix: consume input stream immediately so that the spawned process will not hang if the STDOUT buffer is filled. * fix: fix merge * fix: review comments * fix: refactor to keep ImpersonatedCredentials final (#917) * fix: adds more documentation for InternalProcessBuilder and moves it to the bottom of the file * fix: keep ImpersonatedCredentials final * feat: documents pluggable auth in README * fix: provider * fix: update table of contents * fix: update Co-authored-by: WhiteSource Renovate <bot@renovateapp.com> Co-authored-by: Navina Ramesh <navi.trinity@gmail.com> Co-authored-by: Timur Sadykov <stim@google.com> Co-authored-by: Neenu Shaji <Neenu1995@users.noreply.github.com> Co-authored-by: Jeff Williams <jeffrey.l.williams@gmail.com> Co-authored-by: Emily Ball <emilyball@google.com>
This PR adds support for Compute's instances attached disks.
Attached disks are provided to an instance upon creation or via the attachDisk API. Since
attachDiskonly supports attaching already existing persistent disks (no support for scratch disks or creation on the fly) ourattachDiskmethod (coming in a following PR) will look like:Also the
InstanceInfo.ofmethod will look like:However an instance can be created only if an
AttachedDiskwithPersistentDiskConfigurationorCreateDiskConfigurationis passed, and this method does not enforce that constraint.