Skip to content

feat!: [dataform] remove deprecated v1alpha2 #11481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suztomo merged 2 commits into from
Mar 14, 2025
Merged

feat!: [dataform] remove deprecated v1alpha2 #11481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77f6cbe
chore: remove v1alpha2 from dataform
zhumin8 Mar 11, 2025
b965c56
delete removed modules from google-cloud-dataform-parent pom
zhumin8 Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion generation_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,6 @@ libraries:
product_documentation: https://cloud.google.com/dataform/docs
api_description: Help analytics teams manage data inside BigQuery using SQL.
GAPICs:
- proto_path: google/cloud/dataform/v1alpha2
Copy link
Contributor

@blakeli0 blakeli0 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhumin8 for creating the fix! I thought our default behavior is that if the path does not exist, we would throw errors, @JoeWang1127 can you confirm it? If this is not expected, I think we should create an issue in the backlog to track it.

Copy link
Contributor Author

@zhumin8 zhumin8 Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does throw no such file error, if that's what you mean: #11462 (comment)
But iiuc, we still need manually remove the deleted modules.

FYI - this came to my radar because some other testing 1PP group is doing.

Copy link
Contributor

@blakeli0 blakeli0 Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, that makes sense then. It was by design that we don't want to automatically remove a deprecated module, because it is technically a breaking change.
Can you please change the title to feat! to indicate that it's a breaking change?

- proto_path: google/cloud/dataform/v1beta1

- api_shortname: datalabeling
Expand Down
10 changes: 0 additions & 10 deletions java-dataform/google-cloud-dataform-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,11 @@
<artifactId>google-cloud-dataform</artifactId>
<version>0.59.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-dataform:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-cloud-dataform-v1alpha2</artifactId>
<version>0.59.0-SNAPSHOT</version><!-- {x-version-update:grpc-google-cloud-dataform-v1alpha2:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-cloud-dataform-v1beta1</artifactId>
<version>0.59.0-SNAPSHOT</version><!-- {x-version-update:grpc-google-cloud-dataform-v1beta1:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-dataform-v1alpha2</artifactId>
<version>0.59.0-SNAPSHOT</version><!-- {x-version-update:proto-google-cloud-dataform-v1alpha2:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-dataform-v1beta1</artifactId>
Expand Down
9 changes: 0 additions & 9 deletions java-dataform/google-cloud-dataform/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,6 @@
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-dataform-v1beta1</artifactId>
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-dataform-v1alpha2</artifactId>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
Expand Down Expand Up @@ -92,11 +88,6 @@
<scope>test</scope>
</dependency>

<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-cloud-dataform-v1alpha2</artifactId>
<scope>test</scope>
</dependency>
<!-- Need testing utility classes for generated gRPC clients tests -->
<dependency>
<groupId>com.google.api</groupId>
Expand Down
5,447 changes: 0 additions & 5,447 deletions ...oogle-cloud-dataform/src/main/java/com/google/cloud/dataform/v1alpha2/DataformClient.java
View file
Open in desktop

This file was deleted.

714 changes: 0 additions & 714 deletions ...gle-cloud-dataform/src/main/java/com/google/cloud/dataform/v1alpha2/DataformSettings.java
View file
Open in desktop

This file was deleted.

141 changes: 0 additions & 141 deletions ...oogle-cloud-dataform/src/main/java/com/google/cloud/dataform/v1alpha2/gapic_metadata.json
View file
Open in desktop

This file was deleted.

44 changes: 0 additions & 44 deletions .../google-cloud-dataform/src/main/java/com/google/cloud/dataform/v1alpha2/package-info.java
View file
Open in desktop

This file was deleted.

Loading
Loading