Skip to content

Implement Iterator pull methods, add javadoc and tests#1041

Merged
mziccard merged 1 commit intogoogleapis:pubsub-alphafrom
mziccard:pubsub-pull-iterator
Jun 6, 2016
Merged

Implement Iterator pull methods, add javadoc and tests#1041
mziccard merged 1 commit intogoogleapis:pubsub-alphafrom
mziccard:pubsub-pull-iterator

Conversation

@mziccard
Copy link
Contributor

@mziccard mziccard commented Jun 3, 2016

This PR implements Iterator<ReceivedMessage> pull and Future<Iterator<ReceivedMessage>> pullAsync method.
This PR also:

  • Adds unit tests for pull methods
  • Adds system tests for pull methods, ack/nack messages and renewAckDeadline
  • Add shorter timeout for AckDeadlineRenewer tests
  • Add closed field to both PubSubImpl and DefaultPubSubRpc

@mziccard mziccard added the api: pubsub Issues related to the Pub/Sub API. label Jun 3, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 3, 2016
@coveralls
Copy link

coveralls commented Jun 3, 2016

Coverage Status

Coverage increased (+0.1%) to 85.1% when pulling a881209 on mziccard:pubsub-pull-iterator into e3a6d2e on GoogleCloudPlatform:pubsub-alpha.

@mziccard
Copy link
Contributor Author

mziccard commented Jun 3, 2016

/cc @lesv

lesv
lesv reviewed Jun 6, 2016
View reviewed changes
gcloud-java-pubsub/src/test/java/com/google/cloud/pubsub/PubSubImplTest.java
public void testPullMessages() {
pubsub = new PubSubImpl(options, renewerMock);
PullRequest request = PullRequest.newBuilder()
.setSubscription(SUBSCRIPTION_NAME_PB)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@lesv
Copy link
Contributor

lesv commented Jun 6, 2016

LGTM - codacy/pr doesn't seem happy, but I couldn't find anything I agreed with it on.

@mziccard
Copy link
Contributor Author

mziccard commented Jun 6, 2016

@lesv thanks for the pass!

@mziccard mziccard merged commit 2fd2d56 into googleapis:pubsub-alpha Jun 6, 2016
aozarov
aozarov reviewed Jun 8, 2016
View reviewed changes
gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/PubSubImpl.java

package com.google.cloud.pubsub;

import static com.google.api.client.util.Preconditions.checkArgument;

This comment was marked as spam.

Sign in to view

@aozarov
Copy link
Contributor

aozarov commented Jun 8, 2016

I think this PR has a few things that need to be fixed.

This was referenced Jun 8, 2016
Merged
Merged
mziccard added a commit to mziccard/gcloud-java that referenced this pull request Jun 27, 2016
@mziccard
Implement Iterator pull methods, add javadoc and tests (googleapis#1041)
54e179c
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
@gcf-owl-bot
feat: add model_monitoring_stats_anomalies,model_monitoring_status to…
fe03c60 
… BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto (#1041)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 470845818

Source-Link: googleapis/googleapis@284389e

Source-Link: https://github.com/googleapis/googleapis-gen/commit/29deb79b04aea169a568e7c544868243d5161dde
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjlkZWI3OWIwNGFlYTE2OWE1NjhlN2M1NDQ4NjgyNDNkNTE2MWRkZSJ9
github-actions bot pushed a commit that referenced this pull request Sep 19, 2022
@release-please
chore(main): release 3.3.0 (#1025)
9bd4e09 
🤖 I have created a release *beep* *boop*
---


## [3.3.0](googleapis/java-aiplatform@v3.2.0...v3.3.0) (2022-09-15)


### Features

* add input_artifacts to PipelineJob.runtime_config in aiplatform v1 pipeline_job ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab))
* Add model_monitoring_stats_anomalies,model_monitoring_status to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([#1041](googleapis/java-aiplatform#1041)) ([fe03c60](googleapis/java-aiplatform@fe03c60))
* Add read_mask to ListPipelineJobsRequest in aiplatform v1 pipeline_service ([#1032](googleapis/java-aiplatform#1032)) ([ff7a4ab](googleapis/java-aiplatform@ff7a4ab))
* Add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1 index_service.proto ([#1030](googleapis/java-aiplatform#1030)) ([4114021](googleapis/java-aiplatform@4114021))
* add UpsertDatapoints and RemoveDatapoints rpcs to IndexService in aiplatform v1beta1 index_service.proto ([4114021](googleapis/java-aiplatform@4114021))
* Add WriteFeatureValues in aiplatform v1beta1 featurestore_online_service.proto ([#1022](googleapis/java-aiplatform#1022)) ([267827e](googleapis/java-aiplatform@267827e))


### Dependencies

* Update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.18.0 ([#1021](googleapis/java-aiplatform#1021)) ([c3d34a0](googleapis/java-aiplatform@c3d34a0))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.5 ([#1016](googleapis/java-aiplatform#1016)) ([cc0af7b](googleapis/java-aiplatform@cc0af7b))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.6 ([#1026](googleapis/java-aiplatform#1026)) ([6ed66cc](googleapis/java-aiplatform@6ed66cc))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.14.7 ([#1031](googleapis/java-aiplatform#1031)) ([5adefd4](googleapis/java-aiplatform@5adefd4))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.15.0 ([#1040](googleapis/java-aiplatform#1040)) ([b6c1b20](googleapis/java-aiplatform@b6c1b20))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.16.0 ([#1044](googleapis/java-aiplatform#1044)) ([5ce52e5](googleapis/java-aiplatform@5ce52e5))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#1043](googleapis/java-aiplatform#1043)) ([40eae55](googleapis/java-aiplatform@40eae55))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#1045](googleapis/java-aiplatform#1045)) ([0f66302](googleapis/java-aiplatform@0f66302))
* Update dependency com.google.cloud:google-cloud-storage to v2.11.3 ([#1015](googleapis/java-aiplatform#1015)) ([7a2fcb0](googleapis/java-aiplatform@7a2fcb0))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
@release-please
chore(main): release 2.2.13-SNAPSHOT (#1041)
1702049 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@renovate-bot
deps: update dependency com.google.api.grpc:proto-google-iam-v1 to v1…
0637da1 
….6.20 (#1041)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.api.grpc:proto-google-iam-v1](https://togithub.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://togithub.com/googleapis/java-iam)) | `1.6.18` -> `1.6.20` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.20/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.20/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.20/compatibility-slim/1.6.18)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-iam-v1/1.6.20/confidence-slim/1.6.18)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-iam</summary>

### [`v1.6.20`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;1620-httpsgithubcomgoogleapisjava-iamcomparev1619v1620-2022-11-22)

[Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.19...v1.6.20)

##### Dependencies

-   Update dependency com.google.cloud:google-iam-policy to v1.6.19 ([#&#8203;551](https://togithub.com/googleapis/java-iam/issues/551)) ([cd4a411](https://togithub.com/googleapis/java-iam/commit/cd4a411647e67ebe88c690d6ca4532d4011b4029))

### [`v1.6.19`](https://togithub.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;1619-httpsgithubcomgoogleapisjava-iamcomparev1618v1619-2022-11-22)

[Compare Source](https://togithub.com/googleapis/java-iam/compare/v1.6.18...v1.6.19)

##### Dependencies

-   Update dependency com.google.cloud:google-iam-policy to v1.6.18 ([#&#8203;548](https://togithub.com/googleapis/java-iam/issues/548)) ([34ed3ea](https://togithub.com/googleapis/java-iam/commit/34ed3ea40572a3598d372e9c9d6d5a4077de86d6))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zMC4yIiwidXBkYXRlZEluVmVyIjoiMzQuMzAuMiJ9-->
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@release-please
chore(main): release 3.10.5-SNAPSHOT (#1041)
6d15276 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
@release-please
chore(main): release 0.129.8 (#1041)
e5b5d48 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-iam-admin to v…
5a66ef6 
…1.3.0 (#1041)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-iam-admin](https://togithub.com/googleapis/java-iam-admin) | `1.2.5` -> `1.3.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-iam-admin/1.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-iam-admin/1.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-iam-admin/1.3.0/compatibility-slim/1.2.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-iam-admin/1.3.0/confidence-slim/1.2.5)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-iam-admin</summary>

### [`v1.3.0`](https://togithub.com/googleapis/java-iam-admin/blob/HEAD/CHANGELOG.md#&#8203;130-httpsgithubcomgoogleapisjava-iam-admincomparev125v130-2022-10-03)

[Compare Source](https://togithub.com/googleapis/java-iam-admin/compare/v1.2.5...v1.3.0)

##### Features

-   Replace java_outer_classname option with use_java_stubby_library, add DisableServiceAccountKey and EnableServiceAccountKey, and update comments ([#&#8203;170](https://togithub.com/googleapis/java-iam-admin/issues/170)) ([9aac609](https://togithub.com/googleapis/java-iam-admin/commit/9aac609241998e4f4fdb5373d61f3f2d7c41e4dc))

##### Dependencies

-   Update dependency cachetools to v5 ([#&#8203;177](https://togithub.com/googleapis/java-iam-admin/issues/177)) ([14a70f1](https://togithub.com/googleapis/java-iam-admin/commit/14a70f15a88be6a374eb2a369d30b363c76c33b9))
-   Update dependency certifi to v2022.9.24 ([#&#8203;179](https://togithub.com/googleapis/java-iam-admin/issues/179)) ([717d1d4](https://togithub.com/googleapis/java-iam-admin/commit/717d1d4a2db54db08c8937f4392174eea70aa4a8))
-   Update dependency charset-normalizer to v2.1.1 ([#&#8203;183](https://togithub.com/googleapis/java-iam-admin/issues/183)) ([f8d5fbf](https://togithub.com/googleapis/java-iam-admin/commit/f8d5fbf25b2f4a6f49350ac95abbdd9a3323a6af))
-   Update dependency click to v8.1.3 ([#&#8203;184](https://togithub.com/googleapis/java-iam-admin/issues/184)) ([3dd9f26](https://togithub.com/googleapis/java-iam-admin/commit/3dd9f26db47093de8ca39f17730b80164fcfad3a))
-   Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#&#8203;199](https://togithub.com/googleapis/java-iam-admin/issues/199)) ([08984e9](https://togithub.com/googleapis/java-iam-admin/commit/08984e95aec4cb9b82067f63cb305d3948d3199a))
-   Update dependency gcp-releasetool to v1.8.8 ([#&#8203;180](https://togithub.com/googleapis/java-iam-admin/issues/180)) ([44f56b7](https://togithub.com/googleapis/java-iam-admin/commit/44f56b7644259d9a1c088dbba0cd9b115ad8d79e))
-   Update dependency google-api-core to v2.10.1 ([#&#8203;185](https://togithub.com/googleapis/java-iam-admin/issues/185)) ([aff58c8](https://togithub.com/googleapis/java-iam-admin/commit/aff58c877de0ac542bb5d736b23d066e1b4d3034))
-   Update dependency google-auth to v2.12.0 ([#&#8203;192](https://togithub.com/googleapis/java-iam-admin/issues/192)) ([77a2b4c](https://togithub.com/googleapis/java-iam-admin/commit/77a2b4c277b06dd4c89f9dd22a5523b66925d4ee))
-   Update dependency google-cloud-core to v2.3.2 ([#&#8203;181](https://togithub.com/googleapis/java-iam-admin/issues/181)) ([c6d7cf3](https://togithub.com/googleapis/java-iam-admin/commit/c6d7cf3f57bf6016b15f7dfb07650066370d1c55))
-   Update dependency google-cloud-storage to v2.5.0 ([#&#8203;193](https://togithub.com/googleapis/java-iam-admin/issues/193)) ([c653fd5](https://togithub.com/googleapis/java-iam-admin/commit/c653fd5e1703152235db82c2c3bc432ec4637e37))
-   Update dependency google-crc32c to v1.5.0 ([#&#8203;194](https://togithub.com/googleapis/java-iam-admin/issues/194)) ([13f53b8](https://togithub.com/googleapis/java-iam-admin/commit/13f53b8f99b7f9a59e0675c205fcd8030508e703))
-   Update dependency googleapis-common-protos to v1.56.4 ([#&#8203;182](https://togithub.com/googleapis/java-iam-admin/issues/182)) ([7dd0fad](https://togithub.com/googleapis/java-iam-admin/commit/7dd0faddae40374794eff395846fe9b9fe98bb18))
-   Update dependency importlib-metadata to v4.12.0 ([#&#8203;195](https://togithub.com/googleapis/java-iam-admin/issues/195)) ([5b7dbd4](https://togithub.com/googleapis/java-iam-admin/commit/5b7dbd4e24c75776b60d777d0229b9a9e6c02346))
-   Update dependency jeepney to v0.8.0 ([#&#8203;196](https://togithub.com/googleapis/java-iam-admin/issues/196)) ([e02b609](https://togithub.com/googleapis/java-iam-admin/commit/e02b60996650c2d3c261474a1ab912a95a35b9d0))
-   Update dependency jinja2 to v3.1.2 ([#&#8203;186](https://togithub.com/googleapis/java-iam-admin/issues/186)) ([51e10e0](https://togithub.com/googleapis/java-iam-admin/commit/51e10e089cea3515c9441432ca2eb6894d1d833c))
-   Update dependency keyring to v23.9.3 ([#&#8203;187](https://togithub.com/googleapis/java-iam-admin/issues/187)) ([db3f2af](https://togithub.com/googleapis/java-iam-admin/commit/db3f2af00d57d9048ff481953065fe59ad9b64fa))
-   Update dependency markupsafe to v2.1.1 ([#&#8203;188](https://togithub.com/googleapis/java-iam-admin/issues/188)) ([b56cd55](https://togithub.com/googleapis/java-iam-admin/commit/b56cd55a933b70303777c5d6f11291e2db76ddba))
-   Update dependency protobuf to v3.20.2 ([#&#8203;189](https://togithub.com/googleapis/java-iam-admin/issues/189)) ([210d492](https://togithub.com/googleapis/java-iam-admin/commit/210d492d34a5794c89ebc0dd8232523641b70e4f))
-   Update dependency protobuf to v4 ([#&#8203;178](https://togithub.com/googleapis/java-iam-admin/issues/178)) ([5793368](https://togithub.com/googleapis/java-iam-admin/commit/5793368b1a55f58815e54596f2fa7aba9b5e3c2c))
-   Update dependency pyjwt to v2.5.0 ([#&#8203;190](https://togithub.com/googleapis/java-iam-admin/issues/190)) ([23049b2](https://togithub.com/googleapis/java-iam-admin/commit/23049b2655468518ec1b7a97208972dc8f351768))
-   Update dependency requests to v2.28.1 ([#&#8203;191](https://togithub.com/googleapis/java-iam-admin/issues/191)) ([8ca59d1](https://togithub.com/googleapis/java-iam-admin/commit/8ca59d1dc61928abf964cf9d5f805c5ddce33154))
-   Update dependency typing-extensions to v4.3.0 ([#&#8203;175](https://togithub.com/googleapis/java-iam-admin/issues/175)) ([6e24940](https://togithub.com/googleapis/java-iam-admin/commit/6e2494027fda01b155193188c44d85738a119ae3))
-   Update dependency zipp to v3.8.1 ([#&#8203;176](https://togithub.com/googleapis/java-iam-admin/issues/176)) ([ed17b74](https://togithub.com/googleapis/java-iam-admin/commit/ed17b74ffd3acc928560845120c8c0a4ff38843a))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTQuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNC4wIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mziccard @coveralls @lesv @aozarov @googlebot