-
Notifications
You must be signed in to change notification settings - Fork 194
feat: implement GCE residency detection on Windows #470
Copy link
Copy link
Closed
Labels
type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
See #469
Implement detection of Windows machines as a fallback when the metadata server ping fails. This is already implemented for Linux, but is currently bypassed for Windows.
google-auth-library-php/src/Credentials/GCECredentials.php
Lines 380 to 383 in 23e8e69
| if (PHP_OS === 'Windows') { | |
| // @TODO: implement GCE residency detection on Windows | |
| return false; | |
| } |
Implementation details can be found at go/auth-library-noping, or by discussing with @TimurSadykov or @sai-sunder-s
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.