Add support for methods that directly take `ListOptions` or `ListCursorOptions` to `gen-iterators.go`

[gmlewis]

As demonstrated here, methods that directly use opts *ListOptions or opts *ListCursorOptions are not currently handled by gen-iterators.go.

[Not-Dhananjay-Mishra]

@gmlewis gen-iterators.go generates Iterator for the functions which directly use opts *ListOptions or opts *ListCursorOptions
Here are some example :

go-github/github/github-iterators.go

Lines 17 to 19 in a8a36ab

	// ListEventsIter returns an iterator that paginates through all results of ListEvents.
	func (s *ActivityService) ListEventsIter(ctx context.Context, opts *ListOptions) iter.Seq2[*Event, error] {
	return func(yield func(*Event, error) bool) {

go-github/github/github-iterators.go

Lines 296 to 298 in a8a36ab

	// ListStargazersIter returns an iterator that paginates through all results of ListStargazers.
	func (s *ActivityService) ListStargazersIter(ctx context.Context, owner string, repo string, opts *ListOptions) iter.Seq2[*Stargazer, error] {
	return func(yield func(*Stargazer, error) bool) {

go-github/github/github-iterators.go

Lines 451 to 453 in a8a36ab

	// ListHookDeliveriesIter returns an iterator that paginates through all results of ListHookDeliveries.
	func (s *AppsService) ListHookDeliveriesIter(ctx context.Context, opts *ListCursorOptions) iter.Seq2[*HookDelivery, error] {
	return func(yield func(*HookDelivery, error) bool) {

or I am missing something?

[alexandear]

The gen-iterators.go does not generate an iterator method for the ListReviewers method because it returns a *Reviewers type rather than an array:

func (s *PullRequestsService) ListReviewers(ctx context.Context, owner, repo string, number int, opts *ListOptions) (*Reviewers, *Response, error) { 

[gmlewis]

Yes, you are both all correct. This issue is wrong. Closing.