Add allow_imports option to DEFINE_fiddle_config etc., default True#602
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 9, 2026
Merged
Add allow_imports option to DEFINE_fiddle_config etc., default True#602copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
bot
force-pushed
the
test_880949323
branch
from
080b31b to
b65a8e7
Compare
A later change will flip the default value of this flag to False. Setting this flag to False fixes an RCE security vulnerability that occurs if the Fiddle flags come from an untrusted or less-trusted source. It prevents Fiddle from implicitly loading modules and executing code when dotted names are passed, such as --config=config:foo.bar(). PiperOrigin-RevId: 881035149
copybara-service
bot
force-pushed
the
test_880949323
branch
from
b65a8e7 to
bf94959
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add allow_imports option to DEFINE_fiddle_config etc., default True
A later change will flip the default value of this flag to False.
Setting this flag to False fixes an RCE security vulnerability that occurs if the Fiddle flags come from an untrusted or less-trusted source. It prevents Fiddle from implicitly loading modules and executing code when dotted names are passed, such as --config=config:foo.bar().