dict: Implement __contains__ of dict#65
Merged
corona10 merged 1 commit intogo-python:masterfrom Jul 25, 2019
Merged
Conversation
Collaborator
Author
|
@ncw Can you take a look please? |
ncw
reviewed
Jul 24, 2019
Collaborator
ncw
left a comment
ncw
left a comment
There was a problem hiding this comment.
The code looks great :-)
Can you add some tests?
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 68.44% 68.45% +<.01%
==========================================
Files 59 59
Lines 10488 10495 +7
==========================================
+ Hits 7179 7184 +5
- Misses 2803 2804 +1
- Partials 506 507 +1
Continue to review full report at Codecov.
|
Collaborator
Author
|
@ncw Updated! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement contains of dict for better performance.
ISSUE: #58