Report error when API silently fails to add review comment#1441
Merged
almaleksia merged 2 commits intomainfrom Nov 19, 2025
Merged
Report error when API silently fails to add review comment#1441almaleksia merged 2 commits intomainfrom
almaleksia merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds error detection and reporting when the GitHub GraphQL API silently fails to add a pull request review comment (indicated by an empty thread ID in the response). This commonly occurs when parameters like line numbers are out of range.
- Added validation to check if the thread ID is nil after mutation
- Returns a descriptive error message with hints for fixing common issues
- Updated existing test mock to return a valid thread ID
- Added new test case to verify the error handling for nil thread ID
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/github/pullrequests.go | Added nil check for thread ID after addPullRequestReviewThread mutation with helpful error message explaining possible causes (line number out of range, incorrect file path, invalid side) |
| pkg/github/pullrequests_test.go | Updated existing test mock to return a valid thread ID and added new test case validating error handling when thread ID is nil |
tommaso-moro
approved these changes
Nov 18, 2025
Contributor
tommaso-moro
left a comment
There was a problem hiding this comment.
🚀
Love the hint for the LLM! great touch 💅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When line is out of range GraphQL API doesn't return error and we consider adding PR comment successful though it wasn't posted. The indication that something like this happened is empty thread id. This change adds thread id check and returns error with a hint to LLM how to fix the parameters in the next iteration.
Closes: #1214