Skip to content

Go: Fix bug in ResponseWriter for variadic MaD #16619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owen-mc merged 1 commit into from
Jun 4, 2024
Merged

Go: Fix bug in ResponseWriter for variadic MaD #16619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions go/ql/lib/semmle/go/frameworks/stdlib/NetHttp.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,9 +123,19 @@ module NetHttp {
private DataFlow::Node getSummaryInputOrOutputNode(
DataFlow::CallNode call, SummaryComponentStack stack
) {
exists(int n |
stack = SummaryComponentStack::argument(n) and
result = call.getArgument(n)
exists(int n | result = call.getSyntacticArgument(n) |
if result = call.getImplicitVarargsArgument(_)
then
exists(
int lastParamIndex, SummaryComponentStack varArgsSliceArgument,
SummaryComponent arrayContentSC, DataFlow::ArrayContent arrayContent
|
lastParamIndex = call.getCall().getCalleeType().getNumParameter() - 1 and
varArgsSliceArgument = SummaryComponentStack::argument(lastParamIndex) and
arrayContentSC = SummaryComponent::content(arrayContent) and
stack = SummaryComponentStack::push(arrayContentSC, varArgsSliceArgument)
)
else stack = SummaryComponentStack::argument(n)
)
or
stack = SummaryComponentStack::argument(-1) and
Expand Down