css: improvements to "move the left margin"#471
Merged
chriscool merged 3 commits intogit:masterfrom Dec 2, 2020
felipec:fc/margin
Merged
css: improvements to "move the left margin"#471chriscool merged 3 commits intogit:masterfrom felipec:fc/margin
chriscool merged 3 commits intogit:masterfrom
felipec:fc/margin
Conversation
added 3 commits
December 1, 2020 18:56
This allows the wrapper to fit the whole width of the window, and align the contained elements properly. The width of the navbar is 20em (280px), so the max-width of the site is 940px - 280px, thus retaining the original width. This fixes the issue with "Git Rev News: Edition 68" where the site width was too big, and the navbar width got too small. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
The site container is usually too small, and the navbar usually to big. So adjust their widths. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
The site and the navbar already have 2em between them, there's no need to add another extra 2em. This would be handled much better with a modern grid display. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Contributor
Author
|
This is what the changes look like on the 68th edition: |
Collaborator
|
Ok, let's try this! Thanks @felipec ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @jnareb mentioned in issue #463, it should be possible to "move the left margin" so the navbar isn't squeezed.
However, conceptually what is actually being done is very different: the container wrapper is expanded to the full width of the window, then, the elements inside are justified to the center, this way the browser knows where to place the "left margin" (the left-most location where the navbar starts), but in order for the elements to not expand to the full width of the window, a max-width for the site container is necessary.
While on it, I adjusted the sizes of the navbar and the site containers, and removed some extra unnecessary padding.