update URL references to fix links & styles#113
update URL references to fix links & styles#113brntbeer merged 1 commit intogit:gh-pagesfrom shawnajean:gh-pages
Conversation
|
Thanks for this update, @shawnajean. ❤️ |
brntbeer
left a comment
There was a problem hiding this comment.
Not sure what the best change or proper way forward here is. When i keep all the /s in, the site renders correctly and the links continue to work.
@shawnajean whats the best way for me to test this? When running locally, i was just starting this with jekyll serve.
|
I based the change off of the 404 errors I'm seeing in the console on the current Pages site. With the leading https://git.github.io/css/reset.css Rather than this URL: https://git.github.io/git-reference/css/reset.css The |
brntbeer
left a comment
There was a problem hiding this comment.
@shawnajean Sorry for this sitting for so long! I'm going to approve this now and if we need to, iterate on any nuances
|
as per a quick convo in slack with @shawnajean, im gunna merge this! I have some additional future work that built off this coming soon to a pull request near you |
👋 This removes the leading
/from src and hrefs in the layout files so that the links work and the styles load again since the custom domain was removed.