Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
6019fa2 to
ab12c3d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
kevgo
reviewed
Mar 23, 2024
Contributor
kevgo
left a comment
There was a problem hiding this comment.
This is a really nice solution now! I have really only one major suggestion around (optionally) omitting the stack visualization when there is only one branch in it.
1d2ab9d to
080655e
Compare
Collaborator
Author
|
@kevgo Ready for another round of review 😊. To summarise what I've changed:
There's a couple of review conversations that are still unresolved, as they require further input from you. Keen to hear your thoughts on those! I'm super excited at how things are coming along as well, we're very close I think! 🚀 |
kevgo
approved these changes
Mar 26, 2024
Contributor
kevgo
left a comment
There was a problem hiding this comment.
I think this is ready to go. I have only nitpicks left 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
main