Migrate more type comments to annotations#4651
Merged
sentrivana merged 7 commits intopotel-basefrom Jul 31, 2025
Merged
Conversation
|
| Tests completed | Failed | Passed | Skipped |
|---|---|---|---|
| 18790 | 2 | 18788 | 1027 |
View the top 2 failed test(s) by shortest run time
::tests.integrations.sanic.test_sanicStack Traces | 0s run time
.../integrations/sanic/test_sanic.py:333: in <module> class TransactionTestConfig: .../integrations/sanic/test_sanic.py:346: in TransactionTestConfig has_transaction_event: bool = True, E TypeError: 'ABCMeta' object is not subscriptable
::tests.integrations.sanic.test_sanicStack Traces | 0s run time
.../integrations/sanic/test_sanic.py:333: in <module> class TransactionTestConfig: .../integrations/sanic/test_sanic.py:341: in TransactionTestConfig integration_args: Iterable[Optional[Container[int]]], E TypeError: 'ABCMeta' object is not subscriptable
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
sl0thentr0py
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsure if the types in
testsare any good, but might as well make them into annotations