Merged
Conversation
sl0thentr0py
force-pushed
the
neel/typing
branch
2 times, most recently
from
193076c to
17827c2
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## potel-base #4500 +/- ##
==============================================
+ Coverage 84.84% 84.86% +0.01%
==============================================
Files 144 144
Lines 14882 15005 +123
Branches 2362 2374 +12
==============================================
+ Hits 12627 12734 +107
- Misses 1533 1541 +8
- Partials 722 730 +8
|
sl0thentr0py
force-pushed
the
neel/typing
branch
9 times, most recently
from
f6d64a5 to
4b67774
Compare
sl0thentr0py
commented
Jun 20, 2025
sl0thentr0py
force-pushed
the
neel/typing
branch
from
4b67774 to
c458d9b
Compare
sentrivana
reviewed
Jun 23, 2025
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
Some Qs but overall looks good I think
sl0thentr0py
force-pushed
the
neel/typing
branch
from
64dfb89 to
2bb0ee4
Compare
Member
Author
|
@sentrivana fixed the casts and needed some changes to fix the resulting problems which were actually bad type signatures so fixed those too |
Member
Author
|
also I will keep this draft and stack the other PRs on top and merge all at once into potel-base at the end |
sentrivana
approved these changes
Jun 24, 2025
sl0thentr0py
force-pushed
the
neel/typing
branch
3 times, most recently
from
8544214 to
34c2956
Compare
* remove casts * generalize `is_valid_sample_rate` to return the validated float * added a `validate_scopes` helper method to validate the scopes entry on the context and return the narrowed type * added a `get_typed_attribute` helper method to narrow the type on getting attributes from otel * fix a flaky test on gevent
sl0thentr0py
force-pushed
the
neel/typing
branch
from
e840ee9 to
25d47bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from https://github.com/getsentry/sentry-python/pull/4487/files with lots of manual fixes
# type: blato inline types__future__.annotationsso that we can simply use forward annotations without wrapping them in strings like we did before, this simplifies things substantiallyTYPE_CHECKING, in the future it seems we should avoid usingTYPE_CHECKINGcompletelycloses #2585