Revert traces_sample_rate default change#4362
Closed
antonpirker wants to merge 3 commits intopotel-basefrom
Closed
Revert traces_sample_rate default change#4362antonpirker wants to merge 3 commits intopotel-basefrom
traces_sample_rate default change#4362antonpirker wants to merge 3 commits intopotel-basefrom
Conversation
Member
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
@antonpirker can you link the PR that this PR is reverting for context?
Contributor
Author
|
that's a duplicate of #4335 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default of
traces_sample_rateshould beNone. This was a misunderstanding. With this default tracing without performance (twp) works, and this is the behavior that we like to have.Original change is in this PR: #4335
See also this for better understanding: https://develop.sentry.dev/sdk/telemetry/traces/trace-propagation-cheat-sheet/