Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4299 +/- ##
==========================================
+ Coverage 79.96% 80.31% +0.34%
==========================================
Files 142 142
Lines 15919 15919
Branches 2722 2722
==========================================
+ Hits 12730 12785 +55
+ Misses 2324 2262 -62
- Partials 865 872 +7 |
szokeasaurusrex
left a comment
There was a problem hiding this comment.
small question, looks good otherwise
There was a problem hiding this comment.
shouldn't the hardcoded huggingface_hub items from tox.ini also be getting removed here and/or in the yml template?
There was a problem hiding this comment.
seems like they have not been in tox.ini in the first place...
There was a problem hiding this comment.
yep I think they were missing for some time 🙃
There was a problem hiding this comment.
I went through the rest of the integrations not managed by toxgen to make sure this wasn't the case for other test suites -- we should be good
Also fixes
which started popping up on huggingface_hub 0.30.