feat(logging): Add formatted message to log events#4292
Merged
szokeasaurusrex merged 1 commit intomasterfrom Apr 15, 2025
Merged
feat(logging): Add formatted message to log events#4292szokeasaurusrex merged 1 commit intomasterfrom
szokeasaurusrex merged 1 commit intomasterfrom
Conversation
szokeasaurusrex
requested review from
antonpirker
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4292 +/- ##
==========================================
+ Coverage 79.53% 79.54% +0.01%
==========================================
Files 142 142
Lines 15907 15907
Branches 2722 2722
==========================================
+ Hits 12652 12654 +2
Misses 2389 2389
+ Partials 866 864 -2
|
Send the formatted log event to Sentry in the [`formatted` field](https://develop.sentry.dev/sdk/data-model/event-payloads/message/). This builds on #4291, providing a more robust fix for #3660.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/formatted-logging
branch
from
f4fafea to
296e288
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
Apr 15, 2025
The way the code was written before this change made it look like log records from the `warnings` module were always being handled by a separate code path. In fact, this separate path is only used for Python 3.10 and below. This change makes it clear that the branch is version specific. That way, when we eventually stop supporting 3.10, it is clear that we can delete this separate block. Depends on: - #4292 - #4291
Base automatically changed from
szokeasaurusrex/send-raw-logging-args
to
master
April 15, 2025 08:56
Contributor
Member
Author
|
@sentrivana good idea, I will check the example from #3660 before merging.
In any case, this should not be a breaking change, since we group issues based on the |
Member
Author
|
I tested a log with a 
|
szokeasaurusrex
added a commit
that referenced
this pull request
Apr 15, 2025
The way the code was written before this change made it look like log records from the `warnings` module were always being handled by a separate code path. In fact, this separate path is only used for Python 3.10 and below. This change makes it clear that the branch is version specific. That way, when we eventually stop supporting 3.10, it is clear that we can delete this separate block. Depends on: - #4292 - #4291
antonpirker
pushed a commit
that referenced
this pull request
Apr 15, 2025
The way the code was written before this change made it look like log records from the `warnings` module were always being handled by a separate code path. In fact, this separate path is only used for Python 3.10 and below. This change makes it clear that the branch is version specific. That way, when we eventually stop supporting 3.10, it is clear that we can delete this separate block. Depends on: - #4292 - #4291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Send the formatted log event to Sentry in the
formattedfield.This builds on #4291, providing a more robust fix for #3660.