Add deprecation message to Scope.transaction#4221
Closed
antonpirker wants to merge 1 commit intomasterfrom
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4221 +/- ##
==========================================
+ Coverage 79.48% 79.51% +0.03%
==========================================
Files 141 141
Lines 15809 15810 +1
Branches 2703 2703
==========================================
+ Hits 12565 12572 +7
+ Misses 2382 2380 -2
+ Partials 862 858 -4
|
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
The warning looks good, but it seems like we still use Scope.transaction several places throughout the codebase.
I believe we should first remove those usages, then add the deprecation warning afterwards. Unless, is there some reason why we should instead do this change first?
Contributor
Author
|
Yes you are right. Then it is not worth the effort. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part of #3482