feat(breadcrumbs): add _meta information for truncation of breadcrumbs#4007
Merged
antonpirker merged 25 commits intomasterfrom Apr 3, 2025
Merged
feat(breadcrumbs): add _meta information for truncation of breadcrumbs#4007antonpirker merged 25 commits intomasterfrom
_meta information for truncation of breadcrumbs#4007antonpirker merged 25 commits intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4007 +/- ##
==========================================
+ Coverage 79.51% 79.56% +0.04%
==========================================
Files 142 142
Lines 15876 15894 +18
Branches 2716 2721 +5
==========================================
+ Hits 12624 12646 +22
+ Misses 2388 2381 -7
- Partials 864 867 +3
|
f9d0063 to
06216d8
Compare
Member
szokeasaurusrex
left a comment
There was a problem hiding this comment.
@cleptric given that we want to move towards not truncating any data in SDKs, should we still be implementing this change?
antonpirker
approved these changes
Apr 3, 2025
Contributor
antonpirker
left a comment
There was a problem hiding this comment.
This looks good now! @shellmayr please fix the linting errors so this can be merged.
_meta information for truncation of breadcrumbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements annotations for breadcrumbs
Adds an
intfield toScopeto track the number of truncated breadcrumbsWhen scopes are merged, the number of breadcrumbs that were removed are added
If breadcrumbs were truncated, add the original number of breadcrumbs to
_metaCloses https://github.com/getsentry/projects/issues/593