Merged
Conversation
sl0thentr0py
force-pushed
the
neel/potel/fix-mypy
branch
2 times, most recently
from
48b5b17 to
91fd8d8
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
sl0thentr0py
force-pushed
the
neel/potel/fix-mypy
branch
9 times, most recently
from
1b9e8c2 to
1c1b0a1
Compare
sl0thentr0py
force-pushed
the
neel/potel/fix-mypy
branch
from
1c1b0a1 to
cefce7f
Compare
antonpirker
approved these changes
Jan 21, 2025
Contributor
antonpirker
left a comment
antonpirker
left a comment
There was a problem hiding this comment.
Except for one question, looks good!
| - You can no longer change the sampled status of a span with `span.sampled = False` after starting it. | ||
| - The `Span()` constructor does not accept a `hub` parameter anymore. | ||
| - `Span.finish()` does not accept a `hub` parameter anymore. | ||
| - `Span.finish()` no longer returns the `event_id` if the event is sent to sentry. |
Contributor
There was a problem hiding this comment.
isnt this a problem? I remember that we need the event_id returned by capture_event() or else the user feedback modal can not be used?
Member
Author
There was a problem hiding this comment.
user feedback is for error events, not transactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #3929