Fix tracing tests by sl0thentr0py · Pull Request #3799 · getsentry/sentry-python

sl0thentr0py · 2024-11-18T15:52:36Z

leaving comments in code for explanation

codecov · 2024-11-18T15:55:40Z

❌ 1075 Tests Failed:

Tests completed	Failed	Passed	Skipped
19731	1075	18656	4411

View the top 1 failed tests by shortest run time

tests.test_scope test_with_isolation_scope

Stack Traces | 0.001s run time

tests/test_scope.py:357: in test_with_isolation_scope
    assert scope is in_with_isolation_scope
E   assert <PotelScope id=0x7f0fc213e7b0 name=None type=ScopeType.ISOLATION> is <Scope id=0x7f0fc579ece0 name=None type=ScopeType.ISOLATION>

View the full list of 2 ❄️ flaky tests

tests.test_scope test_with_isolation_scope_data

Flake rate in main: 99.20% (Passed 2 times, Failed 248 times)

Stack Traces | 0.001s run time

tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     
E     Full diff:
E     + {}
E     - {
E     -     'before_isolation_scope': 1,
E     - }

tests.test_scope test_with_new_scope

Flake rate in main: 96.79% (Passed 9 times, Failed 271 times)

Stack Traces | 0.001s run time

tests/test_scope.py:587: in test_with_new_scope
    assert scope is in_with_current_scope
E   assert <PotelScope id=0x7fb2b8fadb80 name=None type=ScopeType.CURRENT> is <Scope id=0x7fb2b8ed1740 name=None type=ScopeType.CURRENT>

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

sl0thentr0py · 2024-11-18T15:53:37Z

sentry_sdk/scope.py

        # type: (Optional[Span]) -> None
        """Set current tracing span."""
        self._span = span
-        # XXX: this differs from the implementation in JS, there Scope.setSpan


removing this opaque behavior, we will not rely on it anymore

sl0thentr0py · 2024-11-18T15:53:53Z

sentry_sdk/integrations/opentelemetry/sampler.py

-        if parent_context.trace_flags.sampled:
-            return True
+        if parent_context.trace_flags.sampled is not None:
+            return parent_context.trace_flags.sampled


fixes bug in the unsampled case

sl0thentr0py · 2024-11-18T15:54:09Z

sentry_sdk/tracing.py

    def is_valid(self):
        # type: () -> bool
-        return self._otel_span.get_span_context().is_valid
+        return self._otel_span.get_span_context().is_valid and isinstance(


fixes another twp bug

sl0thentr0py · 2024-11-18T15:54:55Z

tests/tracing/test_integration_tests.py

-@pytest.mark.parametrize("sampled", [True, False, None])
 @pytest.mark.parametrize("sample_rate", [0.0, 1.0])
-def test_continue_from_headers(sentry_init, capture_envelopes, sampled, sample_rate):
+def test_continue_trace(


simplified this test since it was too confusing and we can write a separate test for explicit sampling later if really wanted

sl0thentr0py · 2024-11-18T15:55:20Z

tests/tracing/test_integration_tests.py



-@pytest.mark.parametrize(
-    "args,expected_refcount",


no longer relevant

sl0thentr0py · 2024-11-18T15:56:01Z

tests/tracing/test_misc.py



-def test_span_trimming(sentry_init, capture_events):
-    sentry_init(traces_sample_rate=1.0, _experiments={"max_spans": 3})


no longer supported, if we want to support max_spans we will need some logic in the span processor but it is not simple to support it

sl0thentr0py · 2024-11-18T15:56:32Z

tests/tracing/test_misc.py

    assert span_data.items() >= {"spanfoo": "spanbar"}.items()


-def test_start_transaction(sentry_init):


most of the following tests are too unit-testy and don't add much or are obsolete.

sl0thentr0py · 2024-11-18T15:57:10Z

tests/tracing/test_propagation.py

-import pytest
-
-
-def test_standalone_span_iter_headers(sentry_init):


there is no longer a difference between a standalone span and a transaction so this is obsolete

sl0thentr0py · 2024-11-18T15:57:48Z

tests/tracing/test_sampling.py

    assert len(events) == 1


-@pytest.mark.parametrize("sampling_decision", [True, False])


no longer true, since unsampled spans can't have attributes and plus I don't see what the point of this test is

sl0thentr0py · 2024-11-18T15:58:17Z

tests/tracing/test_span_name.py

 import sentry_sdk


-def test_start_span_description(sentry_init, capture_events):


we will remove span description completely since it was already deprecated

sentrivana

see couple suggestions, else lgtm

tests/tracing/test_misc.py

tests/tracing/test_propagation.py

sl0thentr0py force-pushed the neel/potel/fix-tracing-tests branch from d31a36c to c5e4a6d Compare November 18, 2024 15:53

sl0thentr0py commented Nov 18, 2024

View reviewed changes

sl0thentr0py requested a review from sentrivana November 18, 2024 15:58

sentrivana approved these changes Nov 18, 2024

View reviewed changes

tests/tracing/test_misc.py Show resolved Hide resolved

tests/tracing/test_misc.py Show resolved Hide resolved

tests/tracing/test_misc.py Show resolved Hide resolved

tests/tracing/test_propagation.py Show resolved Hide resolved

Fix tracing tests

5e6dbbb

sl0thentr0py force-pushed the neel/potel/fix-tracing-tests branch from c5e4a6d to 5e6dbbb Compare November 18, 2024 17:00

sl0thentr0py merged commit 6afa91c into potel-base Nov 18, 2024

sl0thentr0py deleted the neel/potel/fix-tracing-tests branch November 18, 2024 17:13

sl0thentr0py mentioned this pull request Nov 18, 2024

POtel implementation base branch (aka SDK 3.0.0) #3152

Closed

BYK mentioned this pull request Sep 3, 2025

breaking: Remove Spotlight Django integration #4747

Merged



		def test_span_trimming(sentry_init, capture_events):
		sentry_init(traces_sample_rate=1.0, _experiments={"max_spans": 3})

		assert span_data.items() >= {"spanfoo": "spanbar"}.items()


		def test_start_transaction(sentry_init):

		import pytest


		def test_standalone_span_iter_headers(sentry_init):

		assert len(events) == 1


		@pytest.mark.parametrize("sampling_decision", [True, False])

		import sentry_sdk


		def test_start_span_description(sentry_init, capture_events):



		@pytest.mark.parametrize(
		"args,expected_refcount",

Conversation

sl0thentr0py commented Nov 18, 2024

Uh oh!

codecov bot commented Nov 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 1075 Tests Failed:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sentrivana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

codecov bot commented Nov 18, 2024 •

edited

Loading