Fix "indented block" linter error#3468
Merged
szokeasaurusrex merged 3 commits intopotel-basefrom Aug 28, 2024
Merged
Conversation
Fix this [mypy error](https://github.com/getsentry/sentry-python/actions/runs/10390581522/job/28771379618): ``` sentry_sdk/integrations/opentelemetry/potel_span_processor.py:149: error: expected an indented block after function definition on line 31 [syntax] ``` Honestly not sure why this change fixes the problem, maybe there is some bug in `mypy`.
After fixing the previous mypy failure, mypy discovered more syntax problems, which this commit fixes.
Fixing the original mypy error broke the typing; this change fixes the typing.
sl0thentr0py
approved these changes
Aug 27, 2024
Member
Author
|
Looks like linter is still failing, but now there are a bunch more failures that were not detected previously, because the linter failure I fixed was preventing further linting |
❌ 3784 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
sentrivana
approved these changes
Aug 28, 2024
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
Nice work, detective 🎖️
We can merge this even with the new failures -- no need to fix that in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix this strange linter error. Also, fix other mypy errors which mypy only surfaced after fixing the linked linter error, and fix typing in this file, which is broken by the fix for the original mypy error.
It might be easiest to review each of the three commits in this PR individually, since they each build on each other and have through commit messages.