Removing utcnow method deprecated at python3.12 by rmad17 · Pull Request #2415 · getsentry/sentry-python

rmad17 · 2023-10-04T17:18:11Z

Replacing datetime.utcnow() due to deprecation as discussed in #2407

sentrivana · 2023-10-05T08:05:11Z

Thanks for the PR @rmad17! This works for Python 3.12 as well as older Python 3 versions, but we need to support 2.7 too, where datetime.timezone doesn't exist -- there we still need to keep doing it the old way.

My suggestion would be to add a new utcnow() function to the _compat.py file that does datetime.utcnow() for py2.7 and datetime.now(timezone.utc) for py3+, and use that function everywhere.

Please also run black on the codebase afterwards.

sentrivana

See comment above 🙂

…y-python into 2407-support-new-utc-method

rmad17 · 2023-10-05T17:32:31Z

Thanks for the suggestion @sentrivana. I have implemented what you suggested.

hynek · 2023-10-06T07:49:08Z

Should this also fix the same warnings around datetime.datetime.utcfromtimestamp or do y'all prefer a separate PR?

It seems to be called only once AFAICT:

sentry-python/sentry_sdk/integrations/logging.py

Line 285 in 59a67d3

"timestamp": datetime.datetime.utcfromtimestamp(record.created),

sentrivana

Looks good, just one more thing to make it work in py2!

sentry_sdk/_compat.py

sentrivana · 2023-10-06T07:56:07Z

Should this also fix the same warnings around datetime.datetime.utcfromtimestamp or do y'all prefer a separate PR?

It seems to be called only once AFAICT:

sentry-python/sentry_sdk/integrations/logging.py

Line 285 in 59a67d3

"timestamp": datetime.datetime.utcfromtimestamp(record.created),

Ah, good catch. Don't really care much if it gets its own PR.

@rmad17 if you also feel like fixing what @hynek pointed out, feel free to add to this PR (not necessary though!). Otherwise I'll open a new issue for it.

rmad17 · 2023-10-06T12:52:16Z

Thanks @sentrivana for the suggestions. I have made the changes. I have also addressed the issue @hynek pointed out.

sentrivana

Thank you for squeezing in the utcfromtimestamp change as well @rmad17!

I added some typing-related stuff to make the linters happy. We should be good to go!

rmad17 · 2023-10-09T16:59:06Z

Thanks @sentrivana for merging the changes:)

The sentry-sdk 1.32.0 released on 11th of October fixed handling of utcnow to make it future-compatible with Python 3.12. The breadcrumb timestamp returned was naive and now it is timezone aware with utc specified explicitly as timezone. This broke our tests. The change in sentry that impacted it is getsentry/sentry-python#2415 We use the opportunity also to bump sentry sdk minimum version to be 1.32.0 from very old 0.8.0 (from 2019). Sentry is a service, so they generally always want you to use the latest version, and sentry has very little requirements on its own to cause conflicts (for Python 3.8+ it only requires "certifi" without any specific limitations)

…34946) The sentry-sdk 1.32.0 released on 11th of October fixed handling of utcnow to make it future-compatible with Python 3.12. The breadcrumb timestamp returned was naive and now it is timezone aware with utc specified explicitly as timezone. This broke our tests. The change in sentry that impacted it is getsentry/sentry-python#2415 We use the opportunity also to bump sentry sdk minimum version to be 1.32.0 from very old 0.8.0 (from 2019). Sentry is a service, so they generally always want you to use the latest version, and sentry has very little requirements on its own to cause conflicts (for Python 3.8+ it only requires "certifi" without any specific limitations)

…34946) The sentry-sdk 1.32.0 released on 11th of October fixed handling of utcnow to make it future-compatible with Python 3.12. The breadcrumb timestamp returned was naive and now it is timezone aware with utc specified explicitly as timezone. This broke our tests. The change in sentry that impacted it is getsentry/sentry-python#2415 We use the opportunity also to bump sentry sdk minimum version to be 1.32.0 from very old 0.8.0 (from 2019). Sentry is a service, so they generally always want you to use the latest version, and sentry has very little requirements on its own to cause conflicts (for Python 3.8+ it only requires "certifi" without any specific limitations) (cherry picked from commit 91581c4)

…(#34946) The sentry-sdk 1.32.0 released on 11th of October fixed handling of utcnow to make it future-compatible with Python 3.12. The breadcrumb timestamp returned was naive and now it is timezone aware with utc specified explicitly as timezone. This broke our tests. The change in sentry that impacted it is getsentry/sentry-python#2415 We use the opportunity also to bump sentry sdk minimum version to be 1.32.0 from very old 0.8.0 (from 2019). Sentry is a service, so they generally always want you to use the latest version, and sentry has very little requirements on its own to cause conflicts (for Python 3.8+ it only requires "certifi" without any specific limitations) (cherry picked from commit 91581c4991e0f81ac60c64bbaaf31eb51d65922a) GitOrigin-RevId: a2b0a6aab814a773a7ba0a14f648a77d1dfdbb82

…(#34946) The sentry-sdk 1.32.0 released on 11th of October fixed handling of utcnow to make it future-compatible with Python 3.12. The breadcrumb timestamp returned was naive and now it is timezone aware with utc specified explicitly as timezone. This broke our tests. The change in sentry that impacted it is getsentry/sentry-python#2415 We use the opportunity also to bump sentry sdk minimum version to be 1.32.0 from very old 0.8.0 (from 2019). Sentry is a service, so they generally always want you to use the latest version, and sentry has very little requirements on its own to cause conflicts (for Python 3.8+ it only requires "certifi" without any specific limitations) GitOrigin-RevId: 91581c4991e0f81ac60c64bbaaf31eb51d65922a

rmad17 added 2 commits October 4, 2023 07:43

Removing utcnow method deprecated at python3.12

3d8aefe

Merge branch 'master' into 2407-support-new-utc-method

5232d69

sentrivana linked an issue Oct 5, 2023 that may be closed by this pull request

datetime.datetime.utcnow() is deprecated #2407

Closed

sentrivana requested changes Oct 5, 2023

View reviewed changes

rmad17 added 2 commits October 5, 2023 22:59

Added support for python 2.7

7fd8741

Merge branch '2407-support-new-utc-method' of github.com:rmad17/sentr…

0d65835

…y-python into 2407-support-new-utc-method

sentrivana requested changes Oct 6, 2023

View reviewed changes

sentry_sdk/_compat.py Outdated Show resolved Hide resolved

Addressed import issues and utcfromtimestamp deprecation handled as well

44799c9

sentrivana added 2 commits October 9, 2023 09:59

import datetime.datetime where needed for typing

7e55286

add function type annotations

19a8e68

sentrivana self-assigned this Oct 9, 2023

sentrivana approved these changes Oct 9, 2023

View reviewed changes

sentrivana merged commit 99aea33 into getsentry:master Oct 9, 2023

rmad17 deleted the 2407-support-new-utc-method branch October 9, 2023 16:59

potiuk mentioned this pull request Oct 14, 2023

Fix tests to respond to Python 3.12 handling of utcnow in sentry-sdk apache/airflow#34946

Merged

sentrivana mentioned this pull request Oct 25, 2023

Support Python 3.12 #2408

Closed

sentrivana mentioned this pull request Nov 2, 2023

Officially support Python 3.12 #2480

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing utcnow method deprecated at python3.12#2415

Removing utcnow method deprecated at python3.12#2415
sentrivana merged 7 commits intogetsentry:masterfrom
rmad17:2407-support-new-utc-method

rmad17 commented Oct 4, 2023

Uh oh!

sentrivana commented Oct 5, 2023 •

edited

Loading

Uh oh!

sentrivana left a comment

Uh oh!

rmad17 commented Oct 5, 2023

Uh oh!

hynek commented Oct 6, 2023

Uh oh!

sentrivana left a comment

Uh oh!

Uh oh!

sentrivana commented Oct 6, 2023

Uh oh!

rmad17 commented Oct 6, 2023

Uh oh!

sentrivana left a comment

Uh oh!

rmad17 commented Oct 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rmad17 commented Oct 4, 2023

Uh oh!

sentrivana commented Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sentrivana left a comment

Choose a reason for hiding this comment

Uh oh!

rmad17 commented Oct 5, 2023

Uh oh!

hynek commented Oct 6, 2023

Uh oh!

sentrivana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sentrivana commented Oct 6, 2023

Uh oh!

rmad17 commented Oct 6, 2023

Uh oh!

sentrivana left a comment

Choose a reason for hiding this comment

Uh oh!

rmad17 commented Oct 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sentrivana commented Oct 5, 2023 •

edited

Loading