fix(core): Stop rejecting in flush and close when client undefined#3846
Merged
lobsterkatie merged 2 commits intomasterfrom Jul 28, 2021
Merged
fix(core): Stop rejecting in flush and close when client undefined#3846lobsterkatie merged 2 commits intomasterfrom
flush and close when client undefined#3846lobsterkatie merged 2 commits intomasterfrom
Conversation
2 tasks
Member
Author
|
@kamilogorek - I realized after the fact that in the linked issue you'd suggested |
lobsterkatie
force-pushed
the
kmclb-no-rejecting-with-false
branch
from
624f980 to
0d1e647
Compare
Contributor
size-limit report
|
kamilogorek
approved these changes
Jul 28, 2021
Contributor
kamilogorek
left a comment
kamilogorek
left a comment
There was a problem hiding this comment.
I'm fine with warn. Especially that we use it in logAndExitProcess in flush chain.
This was referenced Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if the SDK has no client defined, calling
Sentry.close()orSentry.flush()will result in a promise rejection. Since this is not an error per se, this PR changes that rejection to a logged warning and a promise resolution withfalse. It also fleshes out the docstrings on all of the downstream methods (all of which essentially do the same thing - wait for the event queue to be empty, or timeout if it takes too long).Fixes #3031
Fixes #3746