Skip to content

fix SQLAlchemy deprecated execute param in test#308

Merged
apotterri merged 1 commit intomasterfrom
fix/sqlalchemy-deprecated-execute-param
May 15, 2024
Merged

fix SQLAlchemy deprecated execute param in test#308
apotterri merged 1 commit intomasterfrom
fix/sqlalchemy-deprecated-execute-param

Conversation

@zermelo-wisen
Copy link

@zermelo-wisen zermelo-wisen commented May 15, 2024

Fixes #279.

Copy link
Contributor

@apotterri apotterri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQLAlchemy v1.4 is still getting updates, so we need to continue testing against it.

Can you update the tox config to include an environment that does that, in the same way we test old versions of Django and Flask, please?

@zermelo-wisen zermelo-wisen force-pushed the fix/sqlalchemy-deprecated-execute-param branch from 380c601 to 49f6ca3 Compare May 15, 2024 11:26
@zermelo-wisen
Copy link
Author

SQLAlchemy v1.4 is still getting updates, so we need to continue testing against it.

Can you update the tox config to include an environment that does that, in the same way we test old versions of Django and Flask, please?

Done.

@zermelo-wisen zermelo-wisen requested a review from apotterri May 15, 2024 11:53
@apotterri apotterri force-pushed the fix/sqlalchemy-deprecated-execute-param branch from 49f6ca3 to 9b221bd Compare May 15, 2024 20:54
@apotterri apotterri merged commit fbf85e4 into master May 15, 2024
@apotterri apotterri deleted the fix/sqlalchemy-deprecated-execute-param branch May 15, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support async ORM - sqlalchemy 2.0

3 participants