fix SQLAlchemy deprecated execute param in test#308
Merged
Conversation
apotterri
suggested changes
May 15, 2024
Contributor
apotterri
left a comment
There was a problem hiding this comment.
SQLAlchemy v1.4 is still getting updates, so we need to continue testing against it.
Can you update the tox config to include an environment that does that, in the same way we test old versions of Django and Flask, please?
380c601 to
49f6ca3
Compare
Author
Done. |
49f6ca3 to
9b221bd
Compare
apotterri
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279.
-- Passing a string to
Conneciton.execute()is deprecated in SQLAlchemy 1.4 and removed in 2.0: https://docs.sqlalchemy.org/en/14/core/connections.html#sqlalchemy.engine.Connection.execute-- Changed the tests with warnings issuing a DML with
Connection.execute()to be explicit about commit behavior since auto-commit behavior is changed in 2.0: https://docs.sqlalchemy.org/en/20/changelog/migration_20.html