fix(query-runner): replace .off with .removeListener#10613
Merged
DSchau merged 1 commit intogatsbyjs:masterfrom Dec 21, 2018
wKovacs64:fix/query-runner
Merged
fix(query-runner): replace .off with .removeListener#10613DSchau merged 1 commit intogatsbyjs:masterfrom wKovacs64:fix/query-runner
DSchau merged 1 commit intogatsbyjs:masterfrom
wKovacs64:fix/query-runner
Conversation
DSchau
approved these changes
Dec 21, 2018
Contributor
DSchau
left a comment
DSchau
left a comment
There was a problem hiding this comment.
The MVP :) Thank you! I'll get this released.
Contributor
|
✅ |
Contributor
|
This was referenced Dec 21, 2018
ghost
mentioned this pull request
gpetrioli
pushed a commit
to gpetrioli/gatsby
that referenced
this pull request
Jan 22, 2019
<!-- Have any questions? Check out the contributing docs at https://gatsby.app/contribute, or ask in this Pull Request and a Gatsby maintainer will be happy to help :) --> ## Description <!-- Write a brief description of the changes introduced by this PR --> This fixes a bug introduced in gatsbyjs#10593 by replacing the `.off` call with `.removeListener`. `.off` was introduced in Node v10.0.0 as an alias for `.removeListener` (nodejs/node#17156). ## Related Issues <!-- Link to the issue that is fixed by this PR (if there is one) e.g. Fixes gatsbyjs#1234, Addresses gatsbyjs#1234, Related to gatsbyjs#1234, etc. --> Related to gatsbyjs#10612
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a bug introduced in #10593 by replacing the
.offcall with.removeListener..offwas introduced in Node v10.0.0 as an alias for.removeListener(nodejs/node#17156).Related Issues
Related to #10612