Avoid using displayName as function name since it does not have to be a valid identifier.#59
Open
leidegre wants to merge 2 commits intogaearon:masterfrom
Open
Avoid using displayName as function name since it does not have to be a valid identifier.#59leidegre wants to merge 2 commits intogaearon:masterfrom
leidegre wants to merge 2 commits intogaearon:masterfrom
Conversation
… a valid identifier.
wkwiatek
requested changes
Mar 6, 2017
| return instantiate(() => CurrentComponent, this, arguments); | ||
| }; | ||
| } | ||
| ProxyComponent = function DynamicProxyComponent() { |
Collaborator
There was a problem hiding this comment.
Could you please add some tests to show what problem it solves?
There was a problem hiding this comment.
It's useful for HOCs to wrap the displayName of the base component, for example HigherOrderComponent(BaseComponent). This is not a valid function name however, which causes unnecessary errors to be thrown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very simple solution to the issue discussed in this pull request #58