Config colorize

[uliska]

With HtmlWriter.use_id_or_class() the user now has better control
over how the <pre> element is exported. I did always have to
replace this manually, which was far from convenient.

I will add the respective options to Frescobaldi too.

[uliska]

Yes, and with 7b8b6e9 this has become completely simple. Isn't this now ready to be merged?

[uliska]

Ah, sorry for asking: How about the print and Python2/3 compatiblity?

[PeterBjuhr]

In Python 3 print is a function and a parentheses should be used:

print("print me")

[uliska]

I know that, and I know that one may use workarounds to make code compatible with both 2 and 3. Unfortunately I didn't really follow what happened recently when you made Frescobaldi Python3 compatible, so I don't know if there's a convention to handle that.

Is maybe from __future__ import print_function the adaptor to handle print() in Python2?

Actually running a git grep print shows that using print is not common at all in Frescobaldi, so I suspect that this is not the appropriate approach at all?

[proski]

Please always use from __future__ import print_function when using print and Python 2/3 compatibility is desired. Otherwise, print() output may be different on Python 2 and 3. Frescobaldi is a GUI program, so it's no wonder that print() is uncommon.

[uliska]

Thanks.
So what's the preferred way of notifying the user (of python-ly) of an undesirable situation (such as an invalid attribute name) that doesn't deserve raising an exception?

[PeterBjuhr]

In Frescobaldi print is preferably only used for debugging (you can't expect a user to be able to read the print output). In Python-ly I'm not sure if we have any real cases of print messages to a user. I've used some prints in the MusicXML subpackage but as far as I can recall they are all more or less for debugging.

[PeterBjuhr]

So what's the preferred way of notifying the user (of python-ly) [...]

I have been thinking myself that it could be desirable to notify the user about certain things regarding the MusicXML export.

I guess what we want is a system that works both for GUI and CLI users.

[uliska]

Just realized that the CSS generation has to be updated according to the attribute (# for id and . for class)

[uliska]

@wbsoft I think this PR is now ready to be considered for merging.

[uliska]

@wbsoft bump

[wbsoft]

regarding the print(), I'd raise an exception if a developer provides a wrong value to a function. print() is normally not used in Frescobaldi, only for (temporary) debug purposes.

[uliska]

Thanks for merging. I'll have a second look at the print-s