Skip to content

Improve VMDK#74

Open
Schamper wants to merge 4 commits intomainfrom
improve-vmdk
Open

Improve VMDK#74
Schamper wants to merge 4 commits intomainfrom
improve-vmdk

Conversation

@Schamper
Copy link
Member

@Schamper Schamper commented Dec 30, 2025

Closes #58

Based on #72 for convenience.

TODO:

  • Fix up COWD implementation (need to regenerate test data)
  • Add more test data (e.g. snapshots), perhaps generated on ESXi
  • Add benchmarks and compare to previous implementation

This implementation aims to be a little simpler than the previous one, but we should be wary for performance degradation.

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 86.85897% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.93%. Comparing base (ae08df8) to head (35912c8).

Files with missing lines Patch % Lines
dissect/hypervisor/disk/vmdk.py 86.73% 41 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   80.65%   83.93%   +3.28%     
==========================================
  Files          26       26              
  Lines        2367     2347      -20     
==========================================
+ Hits         1909     1970      +61     
+ Misses        458      377      -81     
Flag Coverage Δ
unittests 83.93% <86.85%> (+3.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Schamper Schamper changed the base branch from main to improve-vdi January 5, 2026 13:25
Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at benchmarking it yet, but this is what I found when testing the implementation

@Schamper Schamper force-pushed the improve-vdi branch 2 times, most recently from 44153f2 to 809f272 Compare February 6, 2026 12:07
Base automatically changed from improve-vdi to main February 18, 2026 15:53
@Schamper
Copy link
Member Author

Fixed the issues and added COWD support. Still need to create some ESXi test data, ideally by expanding generate.sh. Also benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change VMDK implementation to return stream on .open() instead of being a stream

2 participants