Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for parsing BitLocker (FVE) recovery information objects from NTDS and exposes them via the existing NTDS object model.
Changes:
- Introduces a new
MSFVERecoveryInformationNTDS object with convenience accessors for volume/recovery GUIDs, recovery password, and key package. - Adds
Computer.fve_recovery_information()to enumeratemsFVE-RecoveryInformationchild objects for a computer. - Exports
MSFVERecoveryInformationfrom the NTDS objects package.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
dissect/database/ese/ntds/objects/msfve_recoveryinformation.py |
New object wrapper for msFVE-RecoveryInformation with attribute accessors and parent computer linkage. |
dissect/database/ese/ntds/objects/computer.py |
Adds an iterator to yield BitLocker recovery info child objects for a computer. |
dissect/database/ese/ntds/objects/__init__.py |
Registers/exports the new MSFVERecoveryInformation class. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
71cfcba to
b4a462d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 151 152 +1
Lines 4163 4191 +28
=====================================
- Misses 4163 4191 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds parsing of FVE (BitLocker) recovery information. Currently depends on #39 to correctly iterate children objects.