Add extra podLabels options to Flagger Helm Chart#966
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Aug 23, 2021
Merged
Conversation
Signed-off-by: eduardobarbosa <eduardobarbosadacosta@gmail.com>
eduardobarbosa
force-pushed
the
eduardobarbosa/add-podlabels-helmchart
branch
from
8fc27c4 to
3811470
Compare
|
+1 for this one. If you have flagger and the loadtester in the Istio mesh, this allows you to add the required flags to properly label the traffic (otherwise the source_app is |
Codecov Report
@@ Coverage Diff @@
## main #966 +/- ##
==========================================
+ Coverage 56.88% 56.91% +0.03%
==========================================
Files 71 71
Lines 5861 5861
==========================================
+ Hits 3334 3336 +2
+ Misses 2032 2030 -2
Partials 495 495
Continue to review full report at Codecov.
|
stefanprodan
approved these changes
Aug 23, 2021
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @eduardobarbosa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows add extra pod labels to Flagger helm chart.