Merged
Conversation
stefanprodan
requested changes
Mar 5, 2019
cmd/flagger/main.go
Outdated
| flaggerInformerFactory := informers.NewSharedInformerFactory(flaggerClient, time.Second*30) | ||
| var flaggerInformerFactory informers.SharedInformerFactory | ||
| logger.Infof("Flagger Canary 's Watcher is on namespace %s", namespace) | ||
| if namespace == "all" { |
Member
There was a problem hiding this comment.
If the namespace is string empty then NewSharedInformerFactoryWithOptions will create an informer for all namespaces. Please replace the default all with "" and you can delete the if condition.
See https://github.com/kubernetes/client-go/blob/master/informers/factory.go#L110 and https://github.com/kubernetes/apimachinery/blob/master/pkg/apis/meta/v1/types.go#L294
charts/flagger/values.yaml
Outdated
| metricsServer: "http://prometheus.istio-system.svc.cluster.local:9090" | ||
|
|
||
| # Namespace that flagger will watch for Canary objects | ||
| # namespace: default |
Member
There was a problem hiding this comment.
This should be namespace: ""
huydinhle
force-pushed
the
namespace-watcher
branch
2 times, most recently
from
893a146 to
d8cb8f1
Compare
Contributor
Author
|
@stefanprodan addressed the comments |
- introduce the namespace flag for flagger to watch a single namespace for Canary Objects
stefanprodan
approved these changes
Mar 6, 2019
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
Looks good! Thanks @huydinhle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #38
@stefanprodan