pkg/router: update ingress API to networking.k8s.io/v1beta1#534
Merged
stefanprodan merged 4 commits intomasterfrom Mar 30, 2020
Merged
pkg/router: update ingress API to networking.k8s.io/v1beta1#534stefanprodan merged 4 commits intomasterfrom
stefanprodan merged 4 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
=======================================
Coverage 50.69% 50.69%
=======================================
Files 63 63
Lines 4902 4902
=======================================
Hits 2485 2485
Misses 2005 2005
Partials 412 412
Continue to review full report at Codecov.
|
stefanprodan
changed the title
stefanprodan
changed the title
mathetake
approved these changes
Mar 30, 2020
Collaborator
mathetake
left a comment
mathetake
left a comment
There was a problem hiding this comment.
LGTM
thanks @stefanprodan !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
networking.k8s.io/v1beta1in ingress routernetworking.k8s.io/v1beta1Breaking change: drop compatibility with Kubernetes 1.13.
Fix: #533