allow headers to be added to prometheus requests#1757
Merged
aryan9600 merged 1 commit intofluxcd:mainfrom Mar 28, 2025
Merged
Conversation
Signed-off-by: Nick Otter <otternq@gmail.com> Co-authored-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
metric-provider-headers
branch
from
f8438ab to
8f9bb5b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1757 +/- ##
===========================================
- Coverage 39.44% 28.43% -11.01%
===========================================
Files 287 287
Lines 22706 22802 +96
===========================================
- Hits 8956 6484 -2472
- Misses 12777 15596 +2819
+ Partials 973 722 -251 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefanprodan
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update allows the Prometheus metrics provisioner to add HTTP headers to its requests.
I'm specifically adding this to support Grafana Mimir's multi-tenant feature. Mimir looks for the
X-Scope-OrgIDheader to determine which tenant a query is for. Though I haven't tried it, it looks like Thanos also uses headers for multi-tenancy