feat: add disableTLS option for webhooks request#1709
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Nov 23, 2024
Merged
feat: add disableTLS option for webhooks request#1709stefanprodan merged 1 commit intofluxcd:mainfrom
disableTLS option for webhooks request#1709stefanprodan merged 1 commit intofluxcd:mainfrom
Conversation
aryan9600
approved these changes
Oct 6, 2024
Contributor
Author
|
Hi, @stefanprodan @aryan9600 |
Member
|
yes, that's the typical release cadence. |
63226c3 to
3d2e0b4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
==========================================
+ Coverage 35.06% 35.08% +0.02%
==========================================
Files 283 283
Lines 24645 24653 +8
==========================================
+ Hits 8642 8650 +8
Misses 15063 15063
Partials 940 940 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Juan Rodriguez <engineer.jrg@gmail.com>
3d2e0b4 to
8f83838
Compare
disableTLS option for webhooks request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding configurable disableTls option for webhooks.
This is useful in cases where the target service uses self-signed certificates, or you need to connect to an insecure service for testing purposes.