fix(gloo): Update reconciler to detect change in gloo upstream spec#1617
Merged
stefanprodan merged 2 commits intofluxcd:mainfrom Mar 25, 2024
Merged
Conversation
42bff9b to
f646d02
Compare
Signed-off-by: sopida-chotwanwirach <sopida.chotwanwirach@offerup.com>
f646d02 to
e153b8a
Compare
Signed-off-by: sopida-chotwanwirach <sopida.chotwanwirach@offerup.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1617 +/- ##
==========================================
- Coverage 56.60% 56.51% -0.09%
==========================================
Files 85 85
Lines 8549 8571 +22
==========================================
+ Hits 4839 4844 +5
- Misses 3038 3053 +15
- Partials 672 674 +2 ☔ View full report in Codecov by Sentry. |
stefanprodan
approved these changes
Mar 25, 2024
Member
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @sopida-chotwanwirach 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The reconciler is not detecting changes in gloo upstream spec. When the slow start config is added or updated in gloo upstream, the same config is not propagated to existing flagger upstreams.
Reproducing Step:
In PR: