Fix Traefik request-duration metric#1446
Merged
aryan9600 merged 2 commits intofluxcd:mainfrom Aug 28, 2023
Merged
Conversation
miguelvalerio
force-pushed
the
fix-traefik-request-duration
branch
from
565d328 to
3247b58
Compare
Signed-off-by: miguelvalerio <miguelgomes.valerio@gmail.com>
aryan9600
force-pushed
the
fix-traefik-request-duration
branch
from
3247b58 to
c812dcf
Compare
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
stefanprodan
approved these changes
Aug 28, 2023
Member
stefanprodan
left a comment
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @miguelvalerio and @aryan9600
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
request-durationmetric for Traefik returns the results in seconds, however the code assumes it is in milliseconds.This PR fixes that.