Allow access to Prometheus in OpenShift via SA token#1338
Allow access to Prometheus in OpenShift via SA token#1338aryan9600 merged 1 commit intofluxcd:mainfrom
Conversation
aryan9600
left a comment
There was a problem hiding this comment.
thanks for opening this PR!
Codecov ReportBase: 54.24% // Head: 54.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1338 +/- ##
==========================================
+ Coverage 54.24% 54.27% +0.02%
==========================================
Files 84 84
Lines 10016 10022 +6
==========================================
+ Hits 5433 5439 +6
Misses 3927 3927
Partials 656 656
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@wwadge Could you please squash all commits into one? |
f280f27 to
1b17b5d
Compare
Done |
aryan9600
left a comment
There was a problem hiding this comment.
just one small nitpick, and we should be good to go :)
Fixes: fluxcd#1064 Signed-off-by: Wallace Wadge <wwadge@gmail.com>
62fa012 to
a50d7de
Compare
Fixes: #1064
We can already access prometheus using Basic Auth. This PR adds support to access prometheus using Authorization: Bearer token too.
Signed-off-by: Wallace Wadge wwadge@gmail.com