Skip to content

charts: Add namespace parameter to parameters table#1210

Merged
aryan9600 merged 1 commit intofluxcd:mainfrom
aufarg:add-namespace-to-table
Jun 10, 2022
Merged

charts: Add namespace parameter to parameters table#1210
aryan9600 merged 1 commit intofluxcd:mainfrom
aufarg:add-namespace-to-table

Conversation

@aufarg
Copy link
Copy Markdown
Contributor

@aufarg aufarg commented Jun 2, 2022

The README.md for the charts does not have namespace listed on the table although it's configurable on values.yaml

@aufarg aufarg requested a review from stefanprodan as a code owner June 2, 2022 09:19
@aufarg aufarg force-pushed the add-namespace-to-table branch 3 times, most recently from f3d8023 to ec338c3 Compare June 3, 2022 06:24
Copy link
Copy Markdown
Member

@aryan9600 aryan9600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aufarg 🙇

Signed-off-by: Aufar Gilbran <aufargilbran@gmail.com>
@aryan9600 aryan9600 force-pushed the add-namespace-to-table branch from ec338c3 to 703cfd5 Compare June 10, 2022 09:51
@aryan9600 aryan9600 merged commit e4252d8 into fluxcd:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants