fix contour httpproxy annotations overwritten if ingress class selected#1205
Conversation
de61531 to
55b1fe3
Compare
b3013bf to
7b988bf
Compare
Codecov Report
@@ Coverage Diff @@
## main #1205 +/- ##
==========================================
- Coverage 54.96% 54.69% -0.28%
==========================================
Files 79 80 +1
Lines 6642 6823 +181
==========================================
+ Hits 3651 3732 +81
- Misses 2418 2511 +93
- Partials 573 580 +7
Continue to review full report at Codecov.
|
|
@aryan9600 updated with your changes |
|
@BrandonCate lint checking is failing CI, could you fix that, squash all your changes into a single commit and push that? Thanks! |
59959e6 to
0c57db4
Compare
|
@BrandonCate could you please squash all three commits into one commit with the message |
Signed-off-by: brandoncate <brandon.cate@shipt.com>
0c57db4 to
0cecab5
Compare
|
sasquatched |
problem: If ingress class is selected for contour flagger install whenever httpproxy is created the annotations are completely overwritten, not allowing for any custom annotations.
fix: change it so the ingress class annotation is added instead of overriding