Add canary analysis result as Prometheus metrics#1148
Merged
stefanprodan merged 3 commits intofluxcd:mainfrom Apr 6, 2022
Merged
Add canary analysis result as Prometheus metrics#1148stefanprodan merged 3 commits intofluxcd:mainfrom
stefanprodan merged 3 commits intofluxcd:mainfrom
Conversation
Signed-off-by: Ying Liu <ying.liu.lying@gmail.com>
Co-authored-by: Stefan Prodan <stefan.prodan@gmail.com> Signed-off-by: Ying Liu <ying.liu.lying@gmail.com>
c34cd92 to
1348332
Compare
Codecov Report
@@ Coverage Diff @@
## main #1148 +/- ##
==========================================
- Coverage 57.29% 56.78% -0.51%
==========================================
Files 78 79 +1
Lines 6343 6611 +268
==========================================
+ Hits 3634 3754 +120
- Misses 2166 2301 +135
- Partials 543 556 +13
Continue to review full report at Codecov.
|
Author
|
@stefanprodan , updated the PR for the suggested changes. Can you help to review again? Thanks! |
stefanprodan
requested changes
Mar 28, 2022
Member
stefanprodan
left a comment
There was a problem hiding this comment.
Please add these metrics to docs here: https://github.com/fluxcd/flagger/blob/main/docs/gitbook/usage/monitoring.md#metrics
Signed-off-by: Ying Liu <ying.liu.lying@gmail.com>
Author
|
@stefanprodan , updated the PR for the suggested changes. Can you help to review again? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix of #1147
With this code changes, in my demo case, I can get the following metrics:
Let me know if there are any testcase are required.