Remove support for helmv2 in loadtester#1130
Merged
stefanprodan merged 1 commit intofluxcd:mainfrom Mar 9, 2022
Merged
Conversation
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1130 +/- ##
==========================================
+ Coverage 56.99% 57.29% +0.29%
==========================================
Files 79 78 -1
Lines 6376 6343 -33
==========================================
Hits 3634 3634
+ Misses 2199 2166 -33
Partials 543 543 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefanprodan
approved these changes
Mar 8, 2022
Member
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @aryan9600 🏅
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove support for Helm 2 from the loadtester. The webhook types "helm" and "helmv3" are now aliases, both invoke Helm 3.
Fix: #1129
Signed-off-by: Sanskar Jaiswal sanskar.jaiswal@weave.works