Skip to content

Remove support for helmv2 in loadtester#1130

Merged
stefanprodan merged 1 commit intofluxcd:mainfrom
aryan9600:remove-helm2
Mar 9, 2022
Merged

Remove support for helmv2 in loadtester#1130
stefanprodan merged 1 commit intofluxcd:mainfrom
aryan9600:remove-helm2

Conversation

@aryan9600
Copy link
Copy Markdown
Member

@aryan9600 aryan9600 commented Mar 8, 2022

Remove support for Helm 2 from the loadtester. The webhook types "helm" and "helmv3" are now aliases, both invoke Helm 3.

Fix: #1129

Signed-off-by: Sanskar Jaiswal sanskar.jaiswal@weave.works

@aryan9600 aryan9600 requested a review from stefanprodan as a code owner March 8, 2022 16:41
Signed-off-by: Sanskar Jaiswal <sanskar.jaiswal@weave.works>
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 8, 2022

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.29%. Comparing base (090329d) to head (5acf189).
⚠️ Report is 720 commits behind head on main.

Files with missing lines Patch % Lines
pkg/loadtester/helmv3.go 0.00% 1 Missing ⚠️
pkg/loadtester/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
+ Coverage   56.99%   57.29%   +0.29%     
==========================================
  Files          79       78       -1     
  Lines        6376     6343      -33     
==========================================
  Hits         3634     3634              
+ Misses       2199     2166      -33     
  Partials      543      543              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @aryan9600 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

loadtester: Remove Helm v2 binaries

3 participants