Keep quotes when minifying HTML attributes#11904
Merged
Conversation
Collaborator
|
Visit the preview URL for this PR (updated for commit dde24c0): https://flutter-docs-prod--pr11904-fix-quotes-to-attributes-3sz3btgh.web.app |
ericwindmill
approved these changes
Apr 15, 2025
Contributor
|
cc @bkonyi |
kenzieschmoll
added a commit
to flutter/tests
that referenced
this pull request
Apr 17, 2025
Reverts #452 now that flutter/website#11904 has landed and updates the DevTools hash to include a skipped test (flutter/devtools#9150) that was hitting the network against the [test guidelines](https://github.com/flutter/tests?tab=readme-ov-file#adding-more-tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
99d9296 switched to a different HTML minifier which stripped quotes from HTML attributes when technically browsers could parse it, but generally shouldn't be dropped.